threads / patch / 62806

v3meson: fix missing deps for technical articles

Subject: [PATCH v3] meson: fix missing deps for technical articles

## tl;dr

4 messages between Jan 14, 2025 and Jan 14, 2025. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Sam James· Jan 14, 2025, 14:47 UTC · lore

We need an explicit `depends: documentation_deps` so that all of our Documentation targets know they require asciidoc.conf. This shows up as parallel build failures with it not yet being available.

Other targets look OK already.

Signed-off-by: Sam James <sam@gentoo.org>
---
v3: Fixed commit message.
v2: Drop incorrect dep I'd added for api-index.sh as pointed out by Patrick.

 Documentation/technical/meson.build | 1 +
 1 file changed, 1 insertion(+)

Show changes to Documentation/technical/meson.build +1 −0

diff --git a/Documentation/technical/meson.build b/Documentation/technical/meson.build
index 21dfb8b5c9..3a65ee59b3 100644
--- a/Documentation/technical/meson.build
+++ b/Documentation/technical/meson.build
@@ -60,6 +60,7 @@ foreach article : api_docs + articles
     command: asciidoc_html_options,
     input: article,
     output: fs.stem(article) + '.html',
+    depends: documentation_deps,
     install: true,
     install_dir: get_option('datadir') / 'doc/git-doc/technical',
   )

-- 
2.48.0

Patrick Steinhardt· Jan 14, 2025, 15:01 UTC · re: Sam James · lore

Re: [PATCH v3] meson: fix missing deps for technical articles

On Tue, Jan 14, 2025 at 02:47:10PM +0000, Sam James wrote:

Show 10 quoted lines

> We need an explicit `depends: documentation_deps` so that all of our
> Documentation targets know they require asciidoc.conf. This shows up
> as parallel build failures with it not yet being available.
> 
> Other targets look OK already.
> 
> Signed-off-by: Sam James <sam@gentoo.org>
> ---
> v3: Fixed commit message.
> v2: Drop incorrect dep I'd added for api-index.sh as pointed out by Patrick.

Thanks, this version looks good to me.

Patrick

Sam James· Jan 14, 2025, 15:09 UTC · re: Patrick Steinhardt · lore

Re: [PATCH v3] meson: fix missing deps for technical articles

Patrick Steinhardt <ps@pks.im> writes:

Show 13 quoted lines

> On Tue, Jan 14, 2025 at 02:47:10PM +0000, Sam James wrote:
>> We need an explicit `depends: documentation_deps` so that all of our
>> Documentation targets know they require asciidoc.conf. This shows up
>> as parallel build failures with it not yet being available.
>> 
>> Other targets look OK already.
>> 
>> Signed-off-by: Sam James <sam@gentoo.org>
>> ---
>> v3: Fixed commit message.
>> v2: Drop incorrect dep I'd added for api-index.sh as pointed out by Patrick.
>
> Thanks, this version looks good to me.

Thanks, and sorry for the (obvious) errors.

>
> Patrick

Junio C Hamano· Jan 14, 2025, 19:16 UTC · re: Sam James · lore

Re: [PATCH v3] meson: fix missing deps for technical articles

Sam James <sam@gentoo.org> writes:

Show 17 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
>
>> On Tue, Jan 14, 2025 at 02:47:10PM +0000, Sam James wrote:
>>> We need an explicit `depends: documentation_deps` so that all of our
>>> Documentation targets know they require asciidoc.conf. This shows up
>>> as parallel build failures with it not yet being available.
>>> 
>>> Other targets look OK already.
>>> 
>>> Signed-off-by: Sam James <sam@gentoo.org>
>>> ---
>>> v3: Fixed commit message.
>>> v2: Drop incorrect dep I'd added for api-index.sh as pointed out by Patrick.
>>
>> Thanks, this version looks good to me.
>
> Thanks, and sorry for the (obvious) errors.

Thanks, both of you, to working well together and quickly.

Will queue.