{"thread":{"id":"62806","subject":"[PATCH v3] meson: fix missing deps for technical articles","startedAt":"2025-01-14T14:47:57Z","lastAt":"2025-01-14T19:16:05Z","messageCount":4,"participants":["Sam James","Patrick Steinhardt","Junio C Hamano"],"isPatch":true,"patchVersion":3,"patchTotal":null},"messages":[{"id":"510523","messageId":"5114dc9a00377826a55f6bab007d2ad1a4de8bc5.1736866030.git.sam@gentoo.org","threadId":"62806","inReplyTo":null,"subject":"[PATCH v3] meson: fix missing deps for technical articles","fromName":"Sam James","fromEmail":"sam@gentoo.org","sentAt":"2025-01-14T14:47:10Z","receivedAt":"2025-01-14T14:47:57Z","isPatch":true,"sender":{"key":"sam@gentoo.org","avatar":"https://avatars.githubusercontent.com/u/11667869?v=4"},"body":"We need an explicit `depends: documentation_deps` so that all of our\nDocumentation targets know they require asciidoc.conf. This shows up\nas parallel build failures with it not yet being available.\n\nOther targets look OK already.\n\nSigned-off-by: Sam James <sam@gentoo.org>\n---\nv3: Fixed commit message.\nv2: Drop incorrect dep I'd added for api-index.sh as pointed out by Patrick.\n\n Documentation/technical/meson.build | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/Documentation/technical/meson.build b/Documentation/technical/meson.build\nindex 21dfb8b5c9..3a65ee59b3 100644\n--- a/Documentation/technical/meson.build\n+++ b/Documentation/technical/meson.build\n@@ -60,6 +60,7 @@ foreach article : api_docs + articles\n     command: asciidoc_html_options,\n     input: article,\n     output: fs.stem(article) + '.html',\n+    depends: documentation_deps,\n     install: true,\n     install_dir: get_option('datadir') / 'doc/git-doc/technical',\n   )\n-- \n2.48.0\n\n"},{"id":"510524","messageId":"Z4Z8Mg2IME0mveHJ@pks.im","threadId":"62806","inReplyTo":"5114dc9a00377826a55f6bab007d2ad1a4de8bc5.1736866030.git.sam@gentoo.org","subject":"Re: [PATCH v3] meson: fix missing deps for technical articles","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2025-01-14T15:01:06Z","receivedAt":"2025-01-14T15:01:11Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Tue, Jan 14, 2025 at 02:47:10PM +0000, Sam James wrote:\n> We need an explicit `depends: documentation_deps` so that all of our\n> Documentation targets know they require asciidoc.conf. This shows up\n> as parallel build failures with it not yet being available.\n> \n> Other targets look OK already.\n> \n> Signed-off-by: Sam James <sam@gentoo.org>\n> ---\n> v3: Fixed commit message.\n> v2: Drop incorrect dep I'd added for api-index.sh as pointed out by Patrick.\n\nThanks, this version looks good to me.\n\nPatrick\n"},{"id":"510525","messageId":"87a5btwhyk.fsf@gentoo.org","threadId":"62806","inReplyTo":"Z4Z8Mg2IME0mveHJ@pks.im","subject":"Re: [PATCH v3] meson: fix missing deps for technical articles","fromName":"Sam James","fromEmail":"sam@gentoo.org","sentAt":"2025-01-14T15:09:07Z","receivedAt":"2025-01-14T15:09:10Z","isPatch":true,"sender":{"key":"sam@gentoo.org","avatar":"https://avatars.githubusercontent.com/u/11667869?v=4"},"body":"Patrick Steinhardt <ps@pks.im> writes:\n\n> On Tue, Jan 14, 2025 at 02:47:10PM +0000, Sam James wrote:\n>> We need an explicit `depends: documentation_deps` so that all of our\n>> Documentation targets know they require asciidoc.conf. This shows up\n>> as parallel build failures with it not yet being available.\n>> \n>> Other targets look OK already.\n>> \n>> Signed-off-by: Sam James <sam@gentoo.org>\n>> ---\n>> v3: Fixed commit message.\n>> v2: Drop incorrect dep I'd added for api-index.sh as pointed out by Patrick.\n>\n> Thanks, this version looks good to me.\n\nThanks, and sorry for the (obvious) errors.\n\n>\n> Patrick\n"},{"id":"510540","messageId":"xmqqr0552olp.fsf@gitster.g","threadId":"62806","inReplyTo":"87a5btwhyk.fsf@gentoo.org","subject":"Re: [PATCH v3] meson: fix missing deps for technical articles","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-01-14T19:16:02Z","receivedAt":"2025-01-14T19:16:05Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Sam James <sam@gentoo.org> writes:\n\n> Patrick Steinhardt <ps@pks.im> writes:\n>\n>> On Tue, Jan 14, 2025 at 02:47:10PM +0000, Sam James wrote:\n>>> We need an explicit `depends: documentation_deps` so that all of our\n>>> Documentation targets know they require asciidoc.conf. This shows up\n>>> as parallel build failures with it not yet being available.\n>>> \n>>> Other targets look OK already.\n>>> \n>>> Signed-off-by: Sam James <sam@gentoo.org>\n>>> ---\n>>> v3: Fixed commit message.\n>>> v2: Drop incorrect dep I'd added for api-index.sh as pointed out by Patrick.\n>>\n>> Thanks, this version looks good to me.\n>\n> Thanks, and sorry for the (obvious) errors.\n\nThanks, both of you, to working well together and quickly.\n\nWill queue.\n\n"}]}