# [PATCH v3] meson: fix missing deps for technical articles 4 messages from 2025-01-14 to 2025-01-14. Participants: Sam James, Patrick Steinhardt, Junio C Hamano. Thread: https://gitlist.dev/t/62806 ## Sam James, 2025-01-14 14:47 Subject: [PATCH v3] meson: fix missing deps for technical articles Message-ID: <5114dc9a00377826a55f6bab007d2ad1a4de8bc5.1736866030.git.sam@gentoo.org> URL: https://gitlist.dev/e/5114dc9a00377826a55f6bab007d2ad1a4de8bc5.1736866030.git.sam%40gentoo.org ``` We need an explicit `depends: documentation_deps` so that all of our Documentation targets know they require asciidoc.conf. This shows up as parallel build failures with it not yet being available. Other targets look OK already. Signed-off-by: Sam James --- v3: Fixed commit message. v2: Drop incorrect dep I'd added for api-index.sh as pointed out by Patrick. Documentation/technical/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/technical/meson.build b/Documentation/technical/meson.build index 21dfb8b5c9..3a65ee59b3 100644 --- a/Documentation/technical/meson.build +++ b/Documentation/technical/meson.build @@ -60,6 +60,7 @@ foreach article : api_docs + articles command: asciidoc_html_options, input: article, output: fs.stem(article) + '.html', + depends: documentation_deps, install: true, install_dir: get_option('datadir') / 'doc/git-doc/technical', ) -- 2.48.0 ``` ## Patrick Steinhardt, 2025-01-14 15:01 Subject: Re: [PATCH v3] meson: fix missing deps for technical articles Message-ID: URL: https://gitlist.dev/e/Z4Z8Mg2IME0mveHJ%40pks.im In-Reply-To: <5114dc9a00377826a55f6bab007d2ad1a4de8bc5.1736866030.git.sam@gentoo.org> ``` On Tue, Jan 14, 2025 at 02:47:10PM +0000, Sam James wrote: > We need an explicit `depends: documentation_deps` so that all of our > Documentation targets know they require asciidoc.conf. This shows up > as parallel build failures with it not yet being available. > > Other targets look OK already. > > Signed-off-by: Sam James > --- > v3: Fixed commit message. > v2: Drop incorrect dep I'd added for api-index.sh as pointed out by Patrick. Thanks, this version looks good to me. Patrick ``` ## Sam James, 2025-01-14 15:09 Subject: Re: [PATCH v3] meson: fix missing deps for technical articles Message-ID: <87a5btwhyk.fsf@gentoo.org> URL: https://gitlist.dev/e/87a5btwhyk.fsf%40gentoo.org In-Reply-To: ``` Patrick Steinhardt writes: > On Tue, Jan 14, 2025 at 02:47:10PM +0000, Sam James wrote: >> We need an explicit `depends: documentation_deps` so that all of our >> Documentation targets know they require asciidoc.conf. This shows up >> as parallel build failures with it not yet being available. >> >> Other targets look OK already. >> >> Signed-off-by: Sam James >> --- >> v3: Fixed commit message. >> v2: Drop incorrect dep I'd added for api-index.sh as pointed out by Patrick. > > Thanks, this version looks good to me. Thanks, and sorry for the (obvious) errors. > > Patrick ``` ## Junio C Hamano, 2025-01-14 19:16 Subject: Re: [PATCH v3] meson: fix missing deps for technical articles Message-ID: URL: https://gitlist.dev/e/xmqqr0552olp.fsf%40gitster.g In-Reply-To: <87a5btwhyk.fsf@gentoo.org> ``` Sam James writes: > Patrick Steinhardt writes: > >> On Tue, Jan 14, 2025 at 02:47:10PM +0000, Sam James wrote: >>> We need an explicit `depends: documentation_deps` so that all of our >>> Documentation targets know they require asciidoc.conf. This shows up >>> as parallel build failures with it not yet being available. >>> >>> Other targets look OK already. >>> >>> Signed-off-by: Sam James >>> --- >>> v3: Fixed commit message. >>> v2: Drop incorrect dep I'd added for api-index.sh as pointed out by Patrick. >> >> Thanks, this version looks good to me. > > Thanks, and sorry for the (obvious) errors. Thanks, both of you, to working well together and quickly. Will queue. ```