threads / patch / 6259

patch, 2 partsFix up Makefiles

Subject: [PATCH 1/2] Fix up Makefiles

## tl;dr

4 messages between Jan 7, 2007 and Jan 7, 2007. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Horst H. von Brand· Jan 7, 2007, 02:04 UTC · lore

Some guilt fixes

The following two patches clean guilt up a bit. The first one cleans up the Makefiles, the second one runs the tests on the files at hand, not the installed ones (if they exist at all).

Please consider placing a file giving contact information (and how to participate in its development) under Documentation.

I understand you have to point explicitly at the COPYING file in each of the files in the package to make the license stick. Please check this.

-- 
Dr. Horst H. von Brand                   User #22616 counter.li.org
Departamento de Informatica                    Fono: +56 32 2654431
Universidad Tecnica Federico Santa Maria             +56 32 2654239
Casilla 110-V, Valparaiso, Chile               Fax:  +56 32 2797513

Horst H. von Brand· Jan 7, 2007, 02:04 UTC · re: Horst H. von Brand · lore

From: Horst H. von Brand <vonbrand@inf.utfsm.cl>

Signed-off-by: Horst H. von Brand <vonbrand@inf.utfsm.cl>
---
 Makefile            |   11 ++++++++++-
 regression/Makefile |    1 +
 2 files changed, 11 insertions(+), 1 deletions(-)

Show changes to 2 files +11 −1

Makefile, regression/Makefile

diff --git a/Makefile b/Makefile
index a9fb9b7..7e40266 100644
--- a/Makefile
+++ b/Makefile
@@ -1,8 +1,17 @@
 PREFIX=/usr/local
 
+SCRIPTS = guilt guilt-applied guilt-delete guilt-header guilt-init guilt-new guilt-next guilt-pop guilt-prev guilt-push guilt-refresh guilt-series guilt-top guilt-unapplied
+
+.PHONY: all 
 all:
 	echo "Nothing to build, it is all bash :)"
 	echo "Try make install"
 
+.PHONY: install
 install:
-	install guilt* $(PREFIX)/bin/
+	install -m 755 $(SCRIPTS) $(PREFIX)/bin/
+
+.PHONY: test
+test:
+	make -C regression all
+		
diff --git a/regression/Makefile b/regression/Makefile
index c73d5d0..c538029 100644
--- a/regression/Makefile
+++ b/regression/Makefile
@@ -1,2 +1,3 @@
+.PHONY: all
 all:
 	(for x in *.sh ; do sh $$x || exit $?; done)

-- 
1.5.0.rc0.g244a7

Horst H. von Brand· Jan 7, 2007, 02:04 UTC · re: Horst H. von Brand · lore

[PATCH 2/2] Run regression on the current version

From: Horst H. von Brand <vonbrand@inf.utfsm.cl>

Signed-off-by: Horst H. von Brand <vonbrand@inf.utfsm.cl>
---
 regression/scaffold |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Show changes to regression/scaffold +1 −0

diff --git a/regression/scaffold b/regression/scaffold
index f8c813f..ee23d4d 100644
--- a/regression/scaffold
+++ b/regression/scaffold
@@ -3,6 +3,7 @@
 set -e
 
 export REPODIR=/tmp/$RANDOM
+export PATH=$PWD/..:$PATH
 
 function empty_repo
 {

-- 
1.5.0.rc0.g244a7

Josef Sipek· Jan 7, 2007, 06:16 UTC · re: Horst H. von Brand · lore

Re: Some guilt fixes

On Sat, Jan 06, 2007 at 11:04:50PM -0300, Horst H. von Brand wrote:

Show 5 quoted lines

> 
> The following two patches clean guilt up a bit.
> The first one cleans up the Makefiles, the second one
> runs the tests on the files at hand, not the installed ones
> (if they exist at all).

 
Thanks!

> Please consider placing a file giving contact information (and how to
> participate in its development) under Documentation.

Good point.

> I understand you have to point explicitly at the COPYING file in each
> of the files in the package to make the license stick. Please check
> this.

That makes sense.

Thanks a bunch, and congratulations to being the first Guilt contributor. :)

Josef "Jeff" Sipek.

-- 
The reasonable man adapts himself to the world; the unreasonable one
persists in trying to adapt the world to himself. Therefore all progress
depends on the unreasonable man.
		- George Bernard Shaw