{"thread":{"id":"6259","subject":"[PATCH 1/2] Fix up Makefiles","startedAt":"2007-01-07T02:04:50Z","lastAt":"2007-01-07T06:16:50Z","messageCount":4,"participants":["Horst H. von Brand","Josef Sipek"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"31000","messageId":"11681354924120-git-send-email-vonbrand@inf.utfsm.cl","threadId":"6259","inReplyTo":null,"subject":"Some guilt fixes","fromName":"Horst H. von Brand","fromEmail":"vonbrand@inf.utfsm.cl","sentAt":"2007-01-07T02:04:50Z","receivedAt":"2007-01-07T02:04:50Z","isPatch":false,"sender":{"key":"vonbrand@inf.utfsm.cl","avatar":"https://avatars.githubusercontent.com/u/211384?v=4"},"body":"\nThe following two patches clean guilt up a bit.\nThe first one cleans up the Makefiles, the second one\nruns the tests on the files at hand, not the installed ones\n(if they exist at all).\n\nPlease consider placing a file giving contact information (and how to\nparticipate in its development) under Documentation.\n\nI understand you have to point explicitly at the COPYING file in each\nof the files in the package to make the license stick. Please check\nthis.\n-- \nDr. Horst H. von Brand                   User #22616 counter.li.org\nDepartamento de Informatica                    Fono: +56 32 2654431\nUniversidad Tecnica Federico Santa Maria             +56 32 2654239\nCasilla 110-V, Valparaiso, Chile               Fax:  +56 32 2797513\n"},{"id":"30999","messageId":"11681354942365-git-send-email-vonbrand@inf.utfsm.cl","threadId":"6259","inReplyTo":"11681354924120-git-send-email-vonbrand@inf.utfsm.cl","subject":"[PATCH 1/2] Fix up Makefiles","fromName":"Horst H. von Brand","fromEmail":"vonbrand@inf.utfsm.cl","sentAt":"2007-01-07T02:04:51Z","receivedAt":"2007-01-07T02:04:51Z","isPatch":true,"sender":{"key":"vonbrand@inf.utfsm.cl","avatar":"https://avatars.githubusercontent.com/u/211384?v=4"},"body":"From: Horst H. von Brand <vonbrand@inf.utfsm.cl>\n\nSigned-off-by: Horst H. von Brand <vonbrand@inf.utfsm.cl>\n---\n Makefile            |   11 ++++++++++-\n regression/Makefile |    1 +\n 2 files changed, 11 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex a9fb9b7..7e40266 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1,8 +1,17 @@\n PREFIX=/usr/local\n \n+SCRIPTS = guilt guilt-applied guilt-delete guilt-header guilt-init guilt-new guilt-next guilt-pop guilt-prev guilt-push guilt-refresh guilt-series guilt-top guilt-unapplied\n+\n+.PHONY: all \n all:\n \techo \"Nothing to build, it is all bash :)\"\n \techo \"Try make install\"\n \n+.PHONY: install\n install:\n-\tinstall guilt* $(PREFIX)/bin/\n+\tinstall -m 755 $(SCRIPTS) $(PREFIX)/bin/\n+\n+.PHONY: test\n+test:\n+\tmake -C regression all\n+\t\t\ndiff --git a/regression/Makefile b/regression/Makefile\nindex c73d5d0..c538029 100644\n--- a/regression/Makefile\n+++ b/regression/Makefile\n@@ -1,2 +1,3 @@\n+.PHONY: all\n all:\n \t(for x in *.sh ; do sh $$x || exit $?; done)\n-- \n1.5.0.rc0.g244a7\n"},{"id":"31001","messageId":"11681354952305-git-send-email-vonbrand@inf.utfsm.cl","threadId":"6259","inReplyTo":"11681354942365-git-send-email-vonbrand@inf.utfsm.cl","subject":"[PATCH 2/2] Run regression on the current version","fromName":"Horst H. von Brand","fromEmail":"vonbrand@inf.utfsm.cl","sentAt":"2007-01-07T02:04:52Z","receivedAt":"2007-01-07T02:04:52Z","isPatch":true,"sender":{"key":"vonbrand@inf.utfsm.cl","avatar":"https://avatars.githubusercontent.com/u/211384?v=4"},"body":"From: Horst H. von Brand <vonbrand@inf.utfsm.cl>\n\nSigned-off-by: Horst H. von Brand <vonbrand@inf.utfsm.cl>\n---\n regression/scaffold |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/regression/scaffold b/regression/scaffold\nindex f8c813f..ee23d4d 100644\n--- a/regression/scaffold\n+++ b/regression/scaffold\n@@ -3,6 +3,7 @@\n set -e\n \n export REPODIR=/tmp/$RANDOM\n+export PATH=$PWD/..:$PATH\n \n function empty_repo\n {\n-- \n1.5.0.rc0.g244a7\n"},{"id":"31012","messageId":"20070107061650.GD22162@filer.fsl.cs.sunysb.edu","threadId":"6259","inReplyTo":"11681354924120-git-send-email-vonbrand@inf.utfsm.cl","subject":"Re: Some guilt fixes","fromName":"Josef Sipek","fromEmail":"jsipek@fsl.cs.sunysb.edu","sentAt":"2007-01-07T06:16:50Z","receivedAt":"2007-01-07T06:16:50Z","isPatch":false,"sender":{"key":"jsipek@fsl.cs.sunysb.edu","avatar":null},"body":"On Sat, Jan 06, 2007 at 11:04:50PM -0300, Horst H. von Brand wrote:\n> \n> The following two patches clean guilt up a bit.\n> The first one cleans up the Makefiles, the second one\n> runs the tests on the files at hand, not the installed ones\n> (if they exist at all).\n \nThanks!\n \n> Please consider placing a file giving contact information (and how to\n> participate in its development) under Documentation.\n\nGood point.\n\n> I understand you have to point explicitly at the COPYING file in each\n> of the files in the package to make the license stick. Please check\n> this.\n\nThat makes sense.\n\nThanks a bunch, and congratulations to being the first Guilt contributor. :)\n\nJosef \"Jeff\" Sipek.\n\n-- \nThe reasonable man adapts himself to the world; the unreasonable one\npersists in trying to adapt the world to himself. Therefore all progress\ndepends on the unreasonable man.\n\t\t- George Bernard Shaw\n"}]}