# [PATCH 1/2] Fix up Makefiles

4 messages from 2007-01-07 to 2007-01-07. Participants: Horst H. von Brand, Josef Sipek.
Thread: https://gitlist.dev/t/6259

## Horst H. von Brand, 2007-01-07 02:04

Subject: Some guilt fixes
Message-ID: <11681354924120-git-send-email-vonbrand@inf.utfsm.cl>
URL: https://gitlist.dev/e/11681354924120-git-send-email-vonbrand%40inf.utfsm.cl

```

The following two patches clean guilt up a bit.
The first one cleans up the Makefiles, the second one
runs the tests on the files at hand, not the installed ones
(if they exist at all).

Please consider placing a file giving contact information (and how to
participate in its development) under Documentation.

I understand you have to point explicitly at the COPYING file in each
of the files in the package to make the license stick. Please check
this.
-- 
Dr. Horst H. von Brand                   User #22616 counter.li.org
Departamento de Informatica                    Fono: +56 32 2654431
Universidad Tecnica Federico Santa Maria             +56 32 2654239
Casilla 110-V, Valparaiso, Chile               Fax:  +56 32 2797513

```

## Horst H. von Brand, 2007-01-07 02:04

Subject: [PATCH 1/2] Fix up Makefiles
Message-ID: <11681354942365-git-send-email-vonbrand@inf.utfsm.cl>
URL: https://gitlist.dev/e/11681354942365-git-send-email-vonbrand%40inf.utfsm.cl
In-Reply-To: <11681354924120-git-send-email-vonbrand@inf.utfsm.cl>

```
From: Horst H. von Brand <vonbrand@inf.utfsm.cl>

Signed-off-by: Horst H. von Brand <vonbrand@inf.utfsm.cl>
---
 Makefile            |   11 ++++++++++-
 regression/Makefile |    1 +
 2 files changed, 11 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index a9fb9b7..7e40266 100644
--- a/Makefile
+++ b/Makefile
@@ -1,8 +1,17 @@
 PREFIX=/usr/local
 
+SCRIPTS = guilt guilt-applied guilt-delete guilt-header guilt-init guilt-new guilt-next guilt-pop guilt-prev guilt-push guilt-refresh guilt-series guilt-top guilt-unapplied
+
+.PHONY: all 
 all:
 	echo "Nothing to build, it is all bash :)"
 	echo "Try make install"
 
+.PHONY: install
 install:
-	install guilt* $(PREFIX)/bin/
+	install -m 755 $(SCRIPTS) $(PREFIX)/bin/
+
+.PHONY: test
+test:
+	make -C regression all
+		
diff --git a/regression/Makefile b/regression/Makefile
index c73d5d0..c538029 100644
--- a/regression/Makefile
+++ b/regression/Makefile
@@ -1,2 +1,3 @@
+.PHONY: all
 all:
 	(for x in *.sh ; do sh $$x || exit $?; done)
-- 
1.5.0.rc0.g244a7

```

## Horst H. von Brand, 2007-01-07 02:04

Subject: [PATCH 2/2] Run regression on the current version
Message-ID: <11681354952305-git-send-email-vonbrand@inf.utfsm.cl>
URL: https://gitlist.dev/e/11681354952305-git-send-email-vonbrand%40inf.utfsm.cl
In-Reply-To: <11681354942365-git-send-email-vonbrand@inf.utfsm.cl>

```
From: Horst H. von Brand <vonbrand@inf.utfsm.cl>

Signed-off-by: Horst H. von Brand <vonbrand@inf.utfsm.cl>
---
 regression/scaffold |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/regression/scaffold b/regression/scaffold
index f8c813f..ee23d4d 100644
--- a/regression/scaffold
+++ b/regression/scaffold
@@ -3,6 +3,7 @@
 set -e
 
 export REPODIR=/tmp/$RANDOM
+export PATH=$PWD/..:$PATH
 
 function empty_repo
 {
-- 
1.5.0.rc0.g244a7

```

## Josef Sipek, 2007-01-07 06:16

Subject: Re: Some guilt fixes
Message-ID: <20070107061650.GD22162@filer.fsl.cs.sunysb.edu>
URL: https://gitlist.dev/e/20070107061650.GD22162%40filer.fsl.cs.sunysb.edu
In-Reply-To: <11681354924120-git-send-email-vonbrand@inf.utfsm.cl>

```
On Sat, Jan 06, 2007 at 11:04:50PM -0300, Horst H. von Brand wrote:
> 
> The following two patches clean guilt up a bit.
> The first one cleans up the Makefiles, the second one
> runs the tests on the files at hand, not the installed ones
> (if they exist at all).
 
Thanks!
 
> Please consider placing a file giving contact information (and how to
> participate in its development) under Documentation.

Good point.

> I understand you have to point explicitly at the COPYING file in each
> of the files in the package to make the license stick. Please check
> this.

That makes sense.

Thanks a bunch, and congratulations to being the first Guilt contributor. :)

Josef "Jeff" Sipek.

-- 
The reasonable man adapts himself to the world; the unreasonable one
persists in trying to adapt the world to himself. Therefore all progress
depends on the unreasonable man.
		- George Bernard Shaw

```