threads / patch / 6144

patchupdate hook: redirect _both_ diagnostic lines to stderr upon tag failure

Subject: [PATCH] update hook: redirect _both_ diagnostic lines to stderr upon tag failure

## tl;dr

2 messages between Dec 28, 2006 and Dec 28, 2006. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Jim Meyering· Dec 28, 2006, 15:05 UTC · lore

Otherwise, sending the diagnostic to stdout would provoke a protocol failure.
Signed-off-by: Jim Meyering <jim@meyering.net>
---
 templates/hooks--update |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to templates/hooks--update +1 −2

diff --git a/templates/hooks--update b/templates/hooks--update
index 76d5ac2..9863a80 100644
--- a/templates/hooks--update
+++ b/templates/hooks--update
@@ -19,7 +19,7 @@ # Remove this code to treat dumb tags th
 case "$1","$ref_type" in
 refs/tags/*,commit)
 	echo "*** Un-annotated tags are not allowed in this repo" >&2
-	echo "*** Use 'git tag [ -a | -s ]' for tags you want to propagate."
+	echo "*** Use 'git tag [ -a | -s ]' for tags you want to propagate." >&2
 	exit 1;;
 refs/tags/*,tag)
 	echo "### Pushing version '${1##refs/tags/}' to the masses" >&2
--
1.4.2.GIT

Junio C Hamano· Dec 28, 2006, 22:14 UTC · re: Jim Meyering · lore

Re: [PATCH] update hook: redirect _both_ diagnostic lines to stderr upon tag failure

Jim Meyering <jim@meyering.net> writes:

> Otherwise, sending the diagnostic to stdout would provoke a protocol failure.

Very true; thanks for the patch.

However, I suspect that we'd want to prevent this by redirecting on the caller side, so that the hook writers do not have to worry about the issue. I haven't looked at the code that runs the hook for some time but we should be able to do that...