# [PATCH] update hook: redirect _both_ diagnostic lines to stderr upon tag failure 2 messages from 2006-12-28 to 2006-12-28. Participants: Jim Meyering, Junio C Hamano. Thread: https://gitlist.dev/t/6144 ## Jim Meyering, 2006-12-28 15:05 Subject: [PATCH] update hook: redirect _both_ diagnostic lines to stderr upon tag failure Message-ID: <87tzzg6oyp.fsf@rho.meyering.net> URL: https://gitlist.dev/e/87tzzg6oyp.fsf%40rho.meyering.net ``` Otherwise, sending the diagnostic to stdout would provoke a protocol failure. Signed-off-by: Jim Meyering --- templates/hooks--update | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/templates/hooks--update b/templates/hooks--update index 76d5ac2..9863a80 100644 --- a/templates/hooks--update +++ b/templates/hooks--update @@ -19,7 +19,7 @@ # Remove this code to treat dumb tags th case "$1","$ref_type" in refs/tags/*,commit) echo "*** Un-annotated tags are not allowed in this repo" >&2 - echo "*** Use 'git tag [ -a | -s ]' for tags you want to propagate." + echo "*** Use 'git tag [ -a | -s ]' for tags you want to propagate." >&2 exit 1;; refs/tags/*,tag) echo "### Pushing version '${1##refs/tags/}' to the masses" >&2 -- 1.4.2.GIT ``` ## Junio C Hamano, 2006-12-28 22:14 Subject: Re: [PATCH] update hook: redirect _both_ diagnostic lines to stderr upon tag failure Message-ID: <7v8xgrvfac.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7v8xgrvfac.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <87tzzg6oyp.fsf@rho.meyering.net> ``` Jim Meyering writes: > Otherwise, sending the diagnostic to stdout would provoke a protocol failure. Very true; thanks for the patch. However, I suspect that we'd want to prevent this by redirecting on the caller side, so that the hook writers do not have to worry about the issue. I haven't looked at the code that runs the hook for some time but we should be able to do that... ```