{"thread":{"id":"6144","subject":"[PATCH] update hook: redirect _both_ diagnostic lines to stderr upon tag failure","startedAt":"2006-12-28T15:05:02Z","lastAt":"2006-12-28T22:14:51Z","messageCount":2,"participants":["Jim Meyering","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"30439","messageId":"87tzzg6oyp.fsf@rho.meyering.net","threadId":"6144","inReplyTo":null,"subject":"[PATCH] update hook: redirect _both_ diagnostic lines to stderr upon tag failure","fromName":"Jim Meyering","fromEmail":"jim@meyering.net","sentAt":"2006-12-28T15:05:02Z","receivedAt":"2006-12-28T15:05:02Z","isPatch":true,"sender":{"key":"jim@meyering.net","avatar":"https://avatars.githubusercontent.com/u/710630?v=4"},"body":"\nOtherwise, sending the diagnostic to stdout would provoke a protocol failure.\nSigned-off-by: Jim Meyering <jim@meyering.net>\n---\n templates/hooks--update |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/templates/hooks--update b/templates/hooks--update\nindex 76d5ac2..9863a80 100644\n--- a/templates/hooks--update\n+++ b/templates/hooks--update\n@@ -19,7 +19,7 @@ # Remove this code to treat dumb tags th\n case \"$1\",\"$ref_type\" in\n refs/tags/*,commit)\n \techo \"*** Un-annotated tags are not allowed in this repo\" >&2\n-\techo \"*** Use 'git tag [ -a | -s ]' for tags you want to propagate.\"\n+\techo \"*** Use 'git tag [ -a | -s ]' for tags you want to propagate.\" >&2\n \texit 1;;\n refs/tags/*,tag)\n \techo \"### Pushing version '${1##refs/tags/}' to the masses\" >&2\n--\n1.4.2.GIT\n"},{"id":"30445","messageId":"7v8xgrvfac.fsf@assigned-by-dhcp.cox.net","threadId":"6144","inReplyTo":"87tzzg6oyp.fsf@rho.meyering.net","subject":"Re: [PATCH] update hook: redirect _both_ diagnostic lines to stderr upon tag failure","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-12-28T22:14:51Z","receivedAt":"2006-12-28T22:14:51Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jim Meyering <jim@meyering.net> writes:\n\n> Otherwise, sending the diagnostic to stdout would provoke a protocol failure.\n\nVery true; thanks for the patch.\n\nHowever, I suspect that we'd want to prevent this by redirecting\non the caller side, so that the hook writers do not have to\nworry about the issue.  I haven't looked at the code that runs\nthe hook for some time but we should be able to do that...\n"}]}