threads / patch / 60297

patchparse-options: drop unused parse_opt_ctx_t member

Subject: [PATCH] parse-options: drop unused parse_opt_ctx_t member

## tl;dr

3 messages between Oct 3, 2023 and Oct 3, 2023. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

René Scharfe· Oct 3, 2023, 08:55 UTC · lore

5c387428f1 (parse-options: don't emit "ambiguous option" for aliases,
2019-04-29) added "updated_options" to struct parse_opt_ctx_t, but it
has never been used.  Remove it.
---
 parse-options.h | 1 -
 1 file changed, 1 deletion(-)

Show changes to parse-options.h +0 −2

diff --git a/parse-options.h b/parse-options.h
index 57a7fe9d91..4a66ec3bf5 100644
--- a/parse-options.h
+++ b/parse-options.h
@@ -459,7 +459,6 @@ struct parse_opt_ctx_t {
 	unsigned has_subcommands;
 	const char *prefix;
 	const char **alias_groups; /* must be in groups of 3 elements! */
-	struct option *updated_options;
 };

 void parse_options_start(struct parse_opt_ctx_t *ctx,
--
2.42.0

Eric Sunshine· Oct 3, 2023, 17:38 UTC · re: René Scharfe · lore

Re: [PATCH] parse-options: drop unused parse_opt_ctx_t member

On Tue, Oct 3, 2023 at 4:55 AM René Scharfe <l.s.r@web.de> wrote:

> 5c387428f1 (parse-options: don't emit "ambiguous option" for aliases,
> 2019-04-29) added "updated_options" to struct parse_opt_ctx_t, but it
> has never been used.  Remove it.
> ---

Missing sign-off.

René Scharfe· Oct 3, 2023, 18:00 UTC · re: Eric Sunshine · lore

Re: [PATCH] parse-options: drop unused parse_opt_ctx_t member

Am 03.10.23 um 19:38 schrieb Eric Sunshine:

Show 7 quoted lines

> On Tue, Oct 3, 2023 at 4:55 AM René Scharfe <l.s.r@web.de> wrote:
>> 5c387428f1 (parse-options: don't emit "ambiguous option" for aliases,
>> 2019-04-29) added "updated_options" to struct parse_opt_ctx_t, but it
>> has never been used.  Remove it.
>> ---
>
> Missing sign-off.

Oops, thanks for catching that. Technically not necessary, I guess, since the patch is trivial, but here it is:

Signed-off-by: René Scharfe <l.s.r@web.de>