{"thread":{"id":"60297","subject":"[PATCH] parse-options: drop unused parse_opt_ctx_t member","startedAt":"2023-10-03T08:55:27Z","lastAt":"2023-10-03T18:00:47Z","messageCount":3,"participants":["René Scharfe","Eric Sunshine"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"482565","messageId":"ebcaa9e1-d306-4c93-adec-3f35d7040531@web.de","threadId":"60297","inReplyTo":null,"subject":"[PATCH] parse-options: drop unused parse_opt_ctx_t member","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2023-10-03T08:55:21Z","receivedAt":"2023-10-03T08:55:27Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"5c387428f1 (parse-options: don't emit \"ambiguous option\" for aliases,\n2019-04-29) added \"updated_options\" to struct parse_opt_ctx_t, but it\nhas never been used.  Remove it.\n---\n parse-options.h | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/parse-options.h b/parse-options.h\nindex 57a7fe9d91..4a66ec3bf5 100644\n--- a/parse-options.h\n+++ b/parse-options.h\n@@ -459,7 +459,6 @@ struct parse_opt_ctx_t {\n \tunsigned has_subcommands;\n \tconst char *prefix;\n \tconst char **alias_groups; /* must be in groups of 3 elements! */\n-\tstruct option *updated_options;\n };\n\n void parse_options_start(struct parse_opt_ctx_t *ctx,\n--\n2.42.0\n"},{"id":"482576","messageId":"CAPig+cRZ_KzyjWjm-G2qn+t-QA_=CL-tMvTSyZBKrmiHK3RQrg@mail.gmail.com","threadId":"60297","inReplyTo":"ebcaa9e1-d306-4c93-adec-3f35d7040531@web.de","subject":"Re: [PATCH] parse-options: drop unused parse_opt_ctx_t member","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2023-10-03T17:38:19Z","receivedAt":"2023-10-03T17:38:35Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Tue, Oct 3, 2023 at 4:55 AM René Scharfe <l.s.r@web.de> wrote:\n> 5c387428f1 (parse-options: don't emit \"ambiguous option\" for aliases,\n> 2019-04-29) added \"updated_options\" to struct parse_opt_ctx_t, but it\n> has never been used.  Remove it.\n> ---\n\nMissing sign-off.\n"},{"id":"482581","messageId":"77c42646-2fa6-426f-934e-63b71d6355ad@web.de","threadId":"60297","inReplyTo":"CAPig+cRZ_KzyjWjm-G2qn+t-QA_=CL-tMvTSyZBKrmiHK3RQrg@mail.gmail.com","subject":"Re: [PATCH] parse-options: drop unused parse_opt_ctx_t member","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2023-10-03T18:00:40Z","receivedAt":"2023-10-03T18:00:47Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Am 03.10.23 um 19:38 schrieb Eric Sunshine:\n> On Tue, Oct 3, 2023 at 4:55 AM René Scharfe <l.s.r@web.de> wrote:\n>> 5c387428f1 (parse-options: don't emit \"ambiguous option\" for aliases,\n>> 2019-04-29) added \"updated_options\" to struct parse_opt_ctx_t, but it\n>> has never been used.  Remove it.\n>> ---\n>\n> Missing sign-off.\n\nOops, thanks for catching that.  Technically not necessary, I guess,\nsince the patch is trivial, but here it is:\n\nSigned-off-by: René Scharfe <l.s.r@web.de>\n"}]}