# [PATCH] parse-options: drop unused parse_opt_ctx_t member 3 messages from 2023-10-03 to 2023-10-03. Participants: René Scharfe, Eric Sunshine. Thread: https://gitlist.dev/t/60297 ## René Scharfe, 2023-10-03 08:55 Subject: [PATCH] parse-options: drop unused parse_opt_ctx_t member Message-ID: URL: https://gitlist.dev/e/ebcaa9e1-d306-4c93-adec-3f35d7040531%40web.de ``` 5c387428f1 (parse-options: don't emit "ambiguous option" for aliases, 2019-04-29) added "updated_options" to struct parse_opt_ctx_t, but it has never been used. Remove it. --- parse-options.h | 1 - 1 file changed, 1 deletion(-) diff --git a/parse-options.h b/parse-options.h index 57a7fe9d91..4a66ec3bf5 100644 --- a/parse-options.h +++ b/parse-options.h @@ -459,7 +459,6 @@ struct parse_opt_ctx_t { unsigned has_subcommands; const char *prefix; const char **alias_groups; /* must be in groups of 3 elements! */ - struct option *updated_options; }; void parse_options_start(struct parse_opt_ctx_t *ctx, -- 2.42.0 ``` ## Eric Sunshine, 2023-10-03 17:38 Subject: Re: [PATCH] parse-options: drop unused parse_opt_ctx_t member Message-ID: URL: https://gitlist.dev/e/CAPig%2BcRZ_KzyjWjm-G2qn%2Bt-QA_%3DCL-tMvTSyZBKrmiHK3RQrg%40mail.gmail.com In-Reply-To: ``` On Tue, Oct 3, 2023 at 4:55 AM René Scharfe wrote: > 5c387428f1 (parse-options: don't emit "ambiguous option" for aliases, > 2019-04-29) added "updated_options" to struct parse_opt_ctx_t, but it > has never been used. Remove it. > --- Missing sign-off. ``` ## René Scharfe, 2023-10-03 18:00 Subject: Re: [PATCH] parse-options: drop unused parse_opt_ctx_t member Message-ID: <77c42646-2fa6-426f-934e-63b71d6355ad@web.de> URL: https://gitlist.dev/e/77c42646-2fa6-426f-934e-63b71d6355ad%40web.de In-Reply-To: ``` Am 03.10.23 um 19:38 schrieb Eric Sunshine: > On Tue, Oct 3, 2023 at 4:55 AM René Scharfe wrote: >> 5c387428f1 (parse-options: don't emit "ambiguous option" for aliases, >> 2019-04-29) added "updated_options" to struct parse_opt_ctx_t, but it >> has never been used. Remove it. >> --- > > Missing sign-off. Oops, thanks for catching that. Technically not necessary, I guess, since the patch is trivial, but here it is: Signed-off-by: René Scharfe ```