threads / patch / 60093

patcht9001: remove excessive GIT_SEND_EMAIL_NOTTY=1

Subject: [PATCH] t9001: remove excessive GIT_SEND_EMAIL_NOTTY=1

## tl;dr

2 messages between Aug 9, 2023 and Aug 9, 2023. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Oswald Buddenhagen· Aug 9, 2023, 17:15 UTC · lore

This was added by 3ece9bf0f9 (send-email: clear the $message_id after validation, 2023-05-17) for no apparent reason, as this is required only in cases when git's stdin is (must be) redirected, which isn't the case here.

Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>

---
Cc: Junio C Hamano <gitster@pobox.com>
---
 t/t9001-send-email.sh | 1 -
 1 file changed, 1 deletion(-)

Show changes to t/t9001-send-email.sh +0 −1

diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index 48bf0af2ee..c445859f73 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -659,7 +659,6 @@ test_expect_success $PREREQ 'clear message-id before parsing a new message' '
 	clean_fake_sendmail &&
 	echo true | write_script my-hooks/sendemail-validate &&
 	test_config core.hooksPath my-hooks &&
-	GIT_SEND_EMAIL_NOTTY=1 \
 	git send-email --validate --to=recipient@example.com \
 		--smtp-server="$(pwd)/fake.sendmail" \
 		$patches $threaded_patches &&

-- 
2.40.0.152.g15d061e6df

Junio C Hamano· Aug 9, 2023, 19:43 UTC · re: Oswald Buddenhagen · lore

Re: [PATCH] t9001: remove excessive GIT_SEND_EMAIL_NOTTY=1

Oswald Buddenhagen <oswald.buddenhagen@gmx.de> writes:

Show 6 quoted lines

> This was added by 3ece9bf0f9 (send-email: clear the $message_id after
> validation, 2023-05-17) for no apparent reason, as this is required only
> in cases when git's stdin is (must be) redirected, which isn't the case
> here.
>
> Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>

Good eyes.  Thanks, will apply.

Show 19 quoted lines

>
> ---
> Cc: Junio C Hamano <gitster@pobox.com>
> ---
>  t/t9001-send-email.sh | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
> index 48bf0af2ee..c445859f73 100755
> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -659,7 +659,6 @@ test_expect_success $PREREQ 'clear message-id before parsing a new message' '
>  	clean_fake_sendmail &&
>  	echo true | write_script my-hooks/sendemail-validate &&
>  	test_config core.hooksPath my-hooks &&
> -	GIT_SEND_EMAIL_NOTTY=1 \
>  	git send-email --validate --to=recipient@example.com \
>  		--smtp-server="$(pwd)/fake.sendmail" \
>  		$patches $threaded_patches &&