{"thread":{"id":"60093","subject":"[PATCH] t9001: remove excessive GIT_SEND_EMAIL_NOTTY=1","startedAt":"2023-08-09T17:15:42Z","lastAt":"2023-08-09T19:43:27Z","messageCount":2,"participants":["Oswald Buddenhagen","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"480368","messageId":"20230809171531.2564754-1-oswald.buddenhagen@gmx.de","threadId":"60093","inReplyTo":null,"subject":"[PATCH] t9001: remove excessive GIT_SEND_EMAIL_NOTTY=1","fromName":"Oswald Buddenhagen","fromEmail":"oswald.buddenhagen@gmx.de","sentAt":"2023-08-09T17:15:31Z","receivedAt":"2023-08-09T17:15:42Z","isPatch":true,"sender":{"key":"oswald.buddenhagen@gmx.de","avatar":"https://avatars.githubusercontent.com/u/812380?v=4"},"body":"This was added by 3ece9bf0f9 (send-email: clear the $message_id after\nvalidation, 2023-05-17) for no apparent reason, as this is required only\nin cases when git's stdin is (must be) redirected, which isn't the case\nhere.\n\nSigned-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>\n\n---\nCc: Junio C Hamano <gitster@pobox.com>\n---\n t/t9001-send-email.sh | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh\nindex 48bf0af2ee..c445859f73 100755\n--- a/t/t9001-send-email.sh\n+++ b/t/t9001-send-email.sh\n@@ -659,7 +659,6 @@ test_expect_success $PREREQ 'clear message-id before parsing a new message' '\n \tclean_fake_sendmail &&\n \techo true | write_script my-hooks/sendemail-validate &&\n \ttest_config core.hooksPath my-hooks &&\n-\tGIT_SEND_EMAIL_NOTTY=1 \\\n \tgit send-email --validate --to=recipient@example.com \\\n \t\t--smtp-server=\"$(pwd)/fake.sendmail\" \\\n \t\t$patches $threaded_patches &&\n-- \n2.40.0.152.g15d061e6df\n\n"},{"id":"480393","messageId":"xmqq7cq4m27d.fsf@gitster.g","threadId":"60093","inReplyTo":"20230809171531.2564754-1-oswald.buddenhagen@gmx.de","subject":"Re: [PATCH] t9001: remove excessive GIT_SEND_EMAIL_NOTTY=1","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-08-09T19:43:18Z","receivedAt":"2023-08-09T19:43:27Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Oswald Buddenhagen <oswald.buddenhagen@gmx.de> writes:\n\n> This was added by 3ece9bf0f9 (send-email: clear the $message_id after\n> validation, 2023-05-17) for no apparent reason, as this is required only\n> in cases when git's stdin is (must be) redirected, which isn't the case\n> here.\n>\n> Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>\n\nGood eyes.  Thanks, will apply.\n\n\n>\n> ---\n> Cc: Junio C Hamano <gitster@pobox.com>\n> ---\n>  t/t9001-send-email.sh | 1 -\n>  1 file changed, 1 deletion(-)\n>\n> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh\n> index 48bf0af2ee..c445859f73 100755\n> --- a/t/t9001-send-email.sh\n> +++ b/t/t9001-send-email.sh\n> @@ -659,7 +659,6 @@ test_expect_success $PREREQ 'clear message-id before parsing a new message' '\n>  \tclean_fake_sendmail &&\n>  \techo true | write_script my-hooks/sendemail-validate &&\n>  \ttest_config core.hooksPath my-hooks &&\n> -\tGIT_SEND_EMAIL_NOTTY=1 \\\n>  \tgit send-email --validate --to=recipient@example.com \\\n>  \t\t--smtp-server=\"$(pwd)/fake.sendmail\" \\\n>  \t\t$patches $threaded_patches &&\n"}]}