git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t9001: remove excessive GIT_SEND_EMAIL_NOTTY=1

From
Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Date
Aug 9, 2023, 17:15 UTC
Message-ID
<20230809171531.2564754-1-oswald.buddenhagen@gmx.de>

This was added by 3ece9bf0f9 (send-email: clear the $message_id after validation, 2023-05-17) for no apparent reason, as this is required only in cases when git's stdin is (must be) redirected, which isn't the case here.

Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
---
Cc: Junio C Hamano <gitster@pobox.com>
---
 t/t9001-send-email.sh | 1 -
 1 file changed, 1 deletion(-)
diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index 48bf0af2ee..c445859f73 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -659,7 +659,6 @@ test_expect_success $PREREQ 'clear message-id before parsing a new message' '
 	clean_fake_sendmail &&
 	echo true | write_script my-hooks/sendemail-validate &&
 	test_config core.hooksPath my-hooks &&
-	GIT_SEND_EMAIL_NOTTY=1 \
 	git send-email --validate --to=recipient@example.com \
 		--smtp-server="$(pwd)/fake.sendmail" \
 		$patches $threaded_patches &&
-- 
2.40.0.152.g15d061e6df
Next: Junio C Hamano
Message 1 of 2 in “t9001: remove excessive GIT_SEND_EMAIL_NOTTY=1”
  1. t9001: remove excessive GIT_SEND_EMAIL_NOTTY=1Oswald Buddenhagen, Aug 9, 2023
  2. Junio C HamanoAug 9, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.