[PATCH] config: tell the user that we expect an ASCII character

Kristoffer Haugsbakk· Mar 27, 2023, 19:43 UTC · lore

Commit 50b54fd72a (config: be strict on core.commentChar, 2014-05-17) notes that “multi-byte character encoding could also be misinterpreted”, and indeed a multi-byte codepoint (non-ASCII) is not accepted as a valid `core.commentChar`.

Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
---
 config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to config.c +1 −1

diff --git a/config.c b/config.c
index 00090a32fc..ae68c0f736 100644
--- a/config.c
+++ b/config.c
@@ -1683,7 +1683,7 @@ static int git_default_core_config(const char *var, const char *value, void *cb)
 			comment_line_char = value[0];
 			auto_comment_line_char = 0;
 		} else
-			return error(_("core.commentChar should only be one character"));
+			return error(_("core.commentChar should only be one ASCII character"));
 		return 0;
 	}

-- 
2.40.0

Junio C Hamano· Mar 27, 2023, 20:09 UTC · re: Kristoffer Haugsbakk · lore

Re: [PATCH] config: tell the user that we expect an ASCII character

Kristoffer Haugsbakk <code@khaugsbakk.name> writes:

> Commit 50b54fd72a (config: be strict on core.commentChar, 2014-05-17)
> notes that “multi-byte character encoding could also be misinterpreted”,
> and indeed a multi-byte codepoint (non-ASCII) is not accepted as a valid
> `core.commentChar`.

Makes sense.  Will queue.  Thanks.

patchconfig: tell the user that we expect an ASCII character