# [PATCH] config: tell the user that we expect an ASCII character 2 messages from 2023-03-27 to 2023-03-27. Participants: Kristoffer Haugsbakk, Junio C Hamano. Thread: https://gitlist.dev/t/59484 ## Kristoffer Haugsbakk, 2023-03-27 19:43 Subject: [PATCH] config: tell the user that we expect an ASCII character Message-ID: <20230327194344.12910-1-code@khaugsbakk.name> URL: https://gitlist.dev/e/20230327194344.12910-1-code%40khaugsbakk.name ``` Commit 50b54fd72a (config: be strict on core.commentChar, 2014-05-17) notes that “multi-byte character encoding could also be misinterpreted”, and indeed a multi-byte codepoint (non-ASCII) is not accepted as a valid `core.commentChar`. Signed-off-by: Kristoffer Haugsbakk --- config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config.c b/config.c index 00090a32fc..ae68c0f736 100644 --- a/config.c +++ b/config.c @@ -1683,7 +1683,7 @@ static int git_default_core_config(const char *var, const char *value, void *cb) comment_line_char = value[0]; auto_comment_line_char = 0; } else - return error(_("core.commentChar should only be one character")); + return error(_("core.commentChar should only be one ASCII character")); return 0; } -- 2.40.0 ``` ## Junio C Hamano, 2023-03-27 20:09 Subject: Re: [PATCH] config: tell the user that we expect an ASCII character Message-ID: URL: https://gitlist.dev/e/xmqq355q9cs0.fsf%40gitster.g In-Reply-To: <20230327194344.12910-1-code@khaugsbakk.name> ``` Kristoffer Haugsbakk writes: > Commit 50b54fd72a (config: be strict on core.commentChar, 2014-05-17) > notes that “multi-byte character encoding could also be misinterpreted”, > and indeed a multi-byte codepoint (non-ASCII) is not accepted as a valid > `core.commentChar`. Makes sense. Will queue. Thanks. ```