{"thread":{"id":"59484","subject":"[PATCH] config: tell the user that we expect an ASCII character","startedAt":"2023-03-27T19:44:53Z","lastAt":"2023-03-27T20:09:55Z","messageCount":2,"participants":["Kristoffer Haugsbakk","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"474255","messageId":"20230327194344.12910-1-code@khaugsbakk.name","threadId":"59484","inReplyTo":null,"subject":"[PATCH] config: tell the user that we expect an ASCII character","fromName":"Kristoffer Haugsbakk","fromEmail":"code@khaugsbakk.name","sentAt":"2023-03-27T19:43:44Z","receivedAt":"2023-03-27T19:44:53Z","isPatch":true,"sender":{"key":"code@khaugsbakk.name","avatar":"https://avatars.githubusercontent.com/u/2229597?v=4"},"body":"Commit 50b54fd72a (config: be strict on core.commentChar, 2014-05-17)\nnotes that “multi-byte character encoding could also be misinterpreted”,\nand indeed a multi-byte codepoint (non-ASCII) is not accepted as a valid\n`core.commentChar`.\n\nSigned-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>\n---\n config.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/config.c b/config.c\nindex 00090a32fc..ae68c0f736 100644\n--- a/config.c\n+++ b/config.c\n@@ -1683,7 +1683,7 @@ static int git_default_core_config(const char *var, const char *value, void *cb)\n \t\t\tcomment_line_char = value[0];\n \t\t\tauto_comment_line_char = 0;\n \t\t} else\n-\t\t\treturn error(_(\"core.commentChar should only be one character\"));\n+\t\t\treturn error(_(\"core.commentChar should only be one ASCII character\"));\n \t\treturn 0;\n \t}\n \n-- \n2.40.0\n\n"},{"id":"474257","messageId":"xmqq355q9cs0.fsf@gitster.g","threadId":"59484","inReplyTo":"20230327194344.12910-1-code@khaugsbakk.name","subject":"Re: [PATCH] config: tell the user that we expect an ASCII character","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-03-27T20:09:51Z","receivedAt":"2023-03-27T20:09:55Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Kristoffer Haugsbakk <code@khaugsbakk.name> writes:\n\n> Commit 50b54fd72a (config: be strict on core.commentChar, 2014-05-17)\n> notes that “multi-byte character encoding could also be misinterpreted”,\n> and indeed a multi-byte codepoint (non-ASCII) is not accepted as a valid\n> `core.commentChar`.\n\nMakes sense.  Will queue.  Thanks.\n"}]}