threads / patch / 59207

patchconfig.h: remove unused git_configset_add_parameters()

Subject: [PATCH] config.h: remove unused git_configset_add_parameters()

## tl;dr

2 messages between Feb 7, 2023 and Feb 7, 2023. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Ævar Arnfjörð Bjarmason· Feb 7, 2023, 16:15 UTC · lore

This function was removed in ecec57b3c97 (config: respect includes in protected config, 2022-10-13), but its prototype was left here.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---

A trivial cleanup for a change new in v2.39.0.

 config.h | 9 ---------
 1 file changed, 9 deletions(-)

Show changes to config.h +0 −9

diff --git a/config.h b/config.h
index ef9eade6414..7606246531a 100644
--- a/config.h
+++ b/config.h
@@ -447,15 +447,6 @@ void git_configset_init(struct config_set *cs);
  */
 int git_configset_add_file(struct config_set *cs, const char *filename);
 
-/**
- * Parses command line options and environment variables, and adds the
- * variable-value pairs to the `config_set`. Returns 0 on success, or -1
- * if there is an error in parsing. The caller decides whether to free
- * the incomplete configset or continue using it when the function
- * returns -1.
- */
-int git_configset_add_parameters(struct config_set *cs);
-
 /**
  * Finds and returns the value list, sorted in order of increasing priority
  * for the configuration variable `key` and config set `cs`. When the

-- 
2.39.1.1430.gb2471c0aaf4

Glen Choo· Feb 7, 2023, 17:55 UTC · re: Ævar Arnfjörð Bjarmason · lore

Re: [PATCH] config.h: remove unused git_configset_add_parameters()

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> This function was removed in ecec57b3c97 (config: respect includes in
> protected config, 2022-10-13), but its prototype was left here.

Ugh, that's my mistake. Thanks for the catch.

Show 22 quoted lines

> diff --git a/config.h b/config.h
> index ef9eade6414..7606246531a 100644
> --- a/config.h
> +++ b/config.h
> @@ -447,15 +447,6 @@ void git_configset_init(struct config_set *cs);
>   */
>  int git_configset_add_file(struct config_set *cs, const char *filename);
>  
> -/**
> - * Parses command line options and environment variables, and adds the
> - * variable-value pairs to the `config_set`. Returns 0 on success, or -1
> - * if there is an error in parsing. The caller decides whether to free
> - * the incomplete configset or continue using it when the function
> - * returns -1.
> - */
> -int git_configset_add_parameters(struct config_set *cs);
> -
>  /**
>   * Finds and returns the value list, sorted in order of increasing priority
>   * for the configuration variable `key` and config set `cs`. When the
> -- 
> 2.39.1.1430.gb2471c0aaf4

Reviewed-by: Glen Choo <chooglen@google.com>