# [PATCH] config.h: remove unused git_configset_add_parameters() 2 messages from 2023-02-07 to 2023-02-07. Participants: Ævar Arnfjörð Bjarmason, Glen Choo. Thread: https://gitlist.dev/t/59207 ## Ævar Arnfjörð Bjarmason, 2023-02-07 16:15 Subject: [PATCH] config.h: remove unused git_configset_add_parameters() Message-ID: URL: https://gitlist.dev/e/patch-1.1-31f4a08c068-20230207T161453Z-avarab%40gmail.com ``` This function was removed in ecec57b3c97 (config: respect includes in protected config, 2022-10-13), but its prototype was left here. Signed-off-by: Ævar Arnfjörð Bjarmason --- A trivial cleanup for a change new in v2.39.0. config.h | 9 --------- 1 file changed, 9 deletions(-) diff --git a/config.h b/config.h index ef9eade6414..7606246531a 100644 --- a/config.h +++ b/config.h @@ -447,15 +447,6 @@ void git_configset_init(struct config_set *cs); */ int git_configset_add_file(struct config_set *cs, const char *filename); -/** - * Parses command line options and environment variables, and adds the - * variable-value pairs to the `config_set`. Returns 0 on success, or -1 - * if there is an error in parsing. The caller decides whether to free - * the incomplete configset or continue using it when the function - * returns -1. - */ -int git_configset_add_parameters(struct config_set *cs); - /** * Finds and returns the value list, sorted in order of increasing priority * for the configuration variable `key` and config set `cs`. When the -- 2.39.1.1430.gb2471c0aaf4 ``` ## Glen Choo, 2023-02-07 17:55 Subject: Re: [PATCH] config.h: remove unused git_configset_add_parameters() Message-ID: URL: https://gitlist.dev/e/kl6lo7q5icmr.fsf%40chooglen-macbookpro.roam.corp.google.com In-Reply-To: ``` Ævar Arnfjörð Bjarmason writes: > This function was removed in ecec57b3c97 (config: respect includes in > protected config, 2022-10-13), but its prototype was left here. Ugh, that's my mistake. Thanks for the catch. > diff --git a/config.h b/config.h > index ef9eade6414..7606246531a 100644 > --- a/config.h > +++ b/config.h > @@ -447,15 +447,6 @@ void git_configset_init(struct config_set *cs); > */ > int git_configset_add_file(struct config_set *cs, const char *filename); > > -/** > - * Parses command line options and environment variables, and adds the > - * variable-value pairs to the `config_set`. Returns 0 on success, or -1 > - * if there is an error in parsing. The caller decides whether to free > - * the incomplete configset or continue using it when the function > - * returns -1. > - */ > -int git_configset_add_parameters(struct config_set *cs); > - > /** > * Finds and returns the value list, sorted in order of increasing priority > * for the configuration variable `key` and config set `cs`. When the > -- > 2.39.1.1430.gb2471c0aaf4 Reviewed-by: Glen Choo ```