{"thread":{"id":"59207","subject":"[PATCH] config.h: remove unused git_configset_add_parameters()","startedAt":"2023-02-07T16:15:55Z","lastAt":"2023-02-07T17:55:30Z","messageCount":2,"participants":["Ævar Arnfjörð Bjarmason","Glen Choo"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"471696","messageId":"patch-1.1-31f4a08c068-20230207T161453Z-avarab@gmail.com","threadId":"59207","inReplyTo":null,"subject":"[PATCH] config.h: remove unused git_configset_add_parameters()","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2023-02-07T16:15:42Z","receivedAt":"2023-02-07T16:15:55Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"This function was removed in ecec57b3c97 (config: respect includes in\nprotected config, 2022-10-13), but its prototype was left here.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n\nA trivial cleanup for a change new in v2.39.0.\n\n config.h | 9 ---------\n 1 file changed, 9 deletions(-)\n\ndiff --git a/config.h b/config.h\nindex ef9eade6414..7606246531a 100644\n--- a/config.h\n+++ b/config.h\n@@ -447,15 +447,6 @@ void git_configset_init(struct config_set *cs);\n  */\n int git_configset_add_file(struct config_set *cs, const char *filename);\n \n-/**\n- * Parses command line options and environment variables, and adds the\n- * variable-value pairs to the `config_set`. Returns 0 on success, or -1\n- * if there is an error in parsing. The caller decides whether to free\n- * the incomplete configset or continue using it when the function\n- * returns -1.\n- */\n-int git_configset_add_parameters(struct config_set *cs);\n-\n /**\n  * Finds and returns the value list, sorted in order of increasing priority\n  * for the configuration variable `key` and config set `cs`. When the\n-- \n2.39.1.1430.gb2471c0aaf4\n\n"},{"id":"471700","messageId":"kl6lo7q5icmr.fsf@chooglen-macbookpro.roam.corp.google.com","threadId":"59207","inReplyTo":"patch-1.1-31f4a08c068-20230207T161453Z-avarab@gmail.com","subject":"Re: [PATCH] config.h: remove unused git_configset_add_parameters()","fromName":"Glen Choo","fromEmail":"chooglen@google.com","sentAt":"2023-02-07T17:55:24Z","receivedAt":"2023-02-07T17:55:30Z","isPatch":true,"sender":{"key":"glencbz@gmail.com","avatar":"https://avatars.githubusercontent.com/u/58092771?v=4"},"body":"Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:\n\n> This function was removed in ecec57b3c97 (config: respect includes in\n> protected config, 2022-10-13), but its prototype was left here.\n\nUgh, that's my mistake. Thanks for the catch.\n\n> diff --git a/config.h b/config.h\n> index ef9eade6414..7606246531a 100644\n> --- a/config.h\n> +++ b/config.h\n> @@ -447,15 +447,6 @@ void git_configset_init(struct config_set *cs);\n>   */\n>  int git_configset_add_file(struct config_set *cs, const char *filename);\n>  \n> -/**\n> - * Parses command line options and environment variables, and adds the\n> - * variable-value pairs to the `config_set`. Returns 0 on success, or -1\n> - * if there is an error in parsing. The caller decides whether to free\n> - * the incomplete configset or continue using it when the function\n> - * returns -1.\n> - */\n> -int git_configset_add_parameters(struct config_set *cs);\n> -\n>  /**\n>   * Finds and returns the value list, sorted in order of increasing priority\n>   * for the configuration variable `key` and config set `cs`. When the\n> -- \n> 2.39.1.1430.gb2471c0aaf4\n\n\nReviewed-by: Glen Choo <chooglen@google.com>\n"}]}