The current git fails when building rpms:
RPM build errors: Installed (but unpackaged) file(s) found: /usr/lib/perl5/vendor_perl/5.8.6/Git.pm
Indeed git.spec.in does not specify any files for perl-Git, only %files -n perl-Git -f perl-files %defattr(-,root,root) nothing more.
How is this supposed to be handled correctly?
Cheers Anders
Re: rpmbuild fails
On Tuesday 10 October 2006 22:31, Anders Larsen wrote:
> The current git fails when building rpms: > > RPM build errors: > Installed (but unpackaged) file(s) found: > /usr/lib/perl5/vendor_perl/5.8.6/Git.pm
I got the same. I'm no rpm guru, but changing %{perl_vendorarch} into %{perl_vendorlib} in git.spec.in helped for me.
Obviously, the generated perl/Makefile installs Git.pm into the perl vendor *library* directory, and not the arch one.
I do not provide a real patch, as I have no idea if this is really the correct fix (we have no arch-dependent perl files anymore, yes?).
However, something like the above should go into git-1.4.3.
> Indeed git.spec.in does not specify any files for perl-Git, only > %files -n perl-Git -f perl-files > %defattr(-,root,root) > nothing more.
Hmm... Obviously the "... -f perl-files" includes all files mentioned in file "perl-files" into perl-Git. The problem was that without the above change this file was empty.
Josef
Junio C Hamano[RFH] RPM gurus? (Re: rpmbuild fails)
Josef Weidendorfer <Josef.Weidendorfer@gmx.de> writes:
> On Tuesday 10 October 2006 22:31, Anders Larsen wrote:
>> The current git fails when building rpms:
>>
>> RPM build errors:
>> Installed (but unpackaged) file(s) found:
>> /usr/lib/perl5/vendor_perl/5.8.6/Git.pm
>
> I got the same.
> I'm no rpm guru, but changing %{perl_vendorarch} into
> %{perl_vendorlib} in git.spec.in helped for me.
>
> Obviously, the generated perl/Makefile installs Git.pm
> into the perl vendor *library* directory, and not the arch
> one.Thanks.
Also I noticed that we now build-require perl(Error); I have to ask kernel.org people to install it.
Junio C HamanoRe: [RFH] RPM gurus? (Re: rpmbuild fails)
Junio C Hamano <junkio@cox.net> writes:
> Josef Weidendorfer <Josef.Weidendorfer@gmx.de> writes: > >> Obviously, the generated perl/Makefile installs Git.pm >> into the perl vendor *library* directory, and not the arch >> one.
Does this look reasonable?
-- >8 -- git.spec.in: perl subpackage is installed in perl_vendorlib not vendorarch
Signed-off-by: Junio C Hamano <junio@hera.kernel.org> --- git.spec.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git.spec.in b/git.spec.in index 6d90034..9b1217a 100644 --- a/git.spec.in +++ b/git.spec.in @@ -97,7 +97,7 @@ find $RPM_BUILD_ROOT -type f -name '*.bs find $RPM_BUILD_ROOT -type f -name perllocal.pod -exec rm -f {} ';' (find $RPM_BUILD_ROOT%{_bindir} -type f | grep -vE "arch|svn|cvs|email|gitk" | sed -e s@^$RPM_BUILD_ROOT@@) > bin-man-doc-files -(find $RPM_BUILD_ROOT%{perl_vendorarch} -type f | sed -e s@^$RPM_BUILD_ROOT@@) >> perl-files +(find $RPM_BUILD_ROOT%{perl_vendorlib} -type f | sed -e s@^$RPM_BUILD_ROOT@@) >> perl-files %if %{!?_without_docs:1}0 (find $RPM_BUILD_ROOT%{_mandir} $RPM_BUILD_ROOT/Documentation -type f | grep -vE "arch|svn|git-cvs|email|gitk" | sed -e s@^$RPM_BUILD_ROOT@@ -e 's/$/*/' ) >> bin-man-doc-files %else
-- 1.4.3.rc2.gcc59
Re: [RFH] RPM gurus? (Re: rpmbuild fails)
On Wednesday 11 October 2006 10:25, Junio C Hamano wrote:
> Does this look reasonable?
>
> -(find $RPM_BUILD_ROOT%{perl_vendorarch} -type f | sed -e s@^$RPM_BUILD_ROOT@@) >> perl-files
> +(find $RPM_BUILD_ROOT%{perl_vendorlib} -type f | sed -e s@^$RPM_BUILD_ROOT@@) >> perl-filesThat was exactly the modification I did, yes. However, I can only say: It works for me (tm). BTW, this is only Suse 10.1, x86.
Josef