# rpmbuild fails 5 messages from 2006-10-10 to 2006-10-11. Participants: Anders Larsen, Josef Weidendorfer, Junio C Hamano. Thread: https://gitlist.dev/t/5877 ## Anders Larsen, 2006-10-10 20:31 Subject: rpmbuild fails Message-ID: URL: https://gitlist.dev/e/pan.2006.10.10.20.31.48.692444%40alarsen.net ``` The current git fails when building rpms: RPM build errors: Installed (but unpackaged) file(s) found: /usr/lib/perl5/vendor_perl/5.8.6/Git.pm Indeed git.spec.in does not specify any files for perl-Git, only %files -n perl-Git -f perl-files %defattr(-,root,root) nothing more. How is this supposed to be handled correctly? Cheers Anders ``` ## Josef Weidendorfer, 2006-10-10 22:18 Subject: Re: rpmbuild fails Message-ID: <200610110018.19035.Josef.Weidendorfer@gmx.de> URL: https://gitlist.dev/e/200610110018.19035.Josef.Weidendorfer%40gmx.de In-Reply-To: ``` On Tuesday 10 October 2006 22:31, Anders Larsen wrote: > The current git fails when building rpms: > > RPM build errors: > Installed (but unpackaged) file(s) found: > /usr/lib/perl5/vendor_perl/5.8.6/Git.pm I got the same. I'm no rpm guru, but changing %{perl_vendorarch} into %{perl_vendorlib} in git.spec.in helped for me. Obviously, the generated perl/Makefile installs Git.pm into the perl vendor *library* directory, and not the arch one. I do not provide a real patch, as I have no idea if this is really the correct fix (we have no arch-dependent perl files anymore, yes?). However, something like the above should go into git-1.4.3. > Indeed git.spec.in does not specify any files for perl-Git, only > %files -n perl-Git -f perl-files > %defattr(-,root,root) > nothing more. Hmm... Obviously the "... -f perl-files" includes all files mentioned in file "perl-files" into perl-Git. The problem was that without the above change this file was empty. Josef ``` ## Junio C Hamano, 2006-10-11 00:38 Subject: [RFH] RPM gurus? (Re: rpmbuild fails) Message-ID: <7v64erznyj.fsf_-_@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7v64erznyj.fsf_-_%40assigned-by-dhcp.cox.net In-Reply-To: <200610110018.19035.Josef.Weidendorfer@gmx.de> ``` Josef Weidendorfer writes: > On Tuesday 10 October 2006 22:31, Anders Larsen wrote: >> The current git fails when building rpms: >> >> RPM build errors: >> Installed (but unpackaged) file(s) found: >> /usr/lib/perl5/vendor_perl/5.8.6/Git.pm > > I got the same. > I'm no rpm guru, but changing %{perl_vendorarch} into > %{perl_vendorlib} in git.spec.in helped for me. > > Obviously, the generated perl/Makefile installs Git.pm > into the perl vendor *library* directory, and not the arch > one. Thanks. Also I noticed that we now build-require perl(Error); I have to ask kernel.org people to install it. ``` ## Junio C Hamano, 2006-10-11 08:25 Subject: Re: [RFH] RPM gurus? (Re: rpmbuild fails) Message-ID: <7vpscztg1c.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vpscztg1c.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <7v64erznyj.fsf_-_@assigned-by-dhcp.cox.net> ``` Junio C Hamano writes: > Josef Weidendorfer writes: > >> Obviously, the generated perl/Makefile installs Git.pm >> into the perl vendor *library* directory, and not the arch >> one. Does this look reasonable? -- >8 -- git.spec.in: perl subpackage is installed in perl_vendorlib not vendorarch Signed-off-by: Junio C Hamano --- git.spec.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/git.spec.in b/git.spec.in index 6d90034..9b1217a 100644 --- a/git.spec.in +++ b/git.spec.in @@ -97,7 +97,7 @@ find $RPM_BUILD_ROOT -type f -name '*.bs find $RPM_BUILD_ROOT -type f -name perllocal.pod -exec rm -f {} ';' (find $RPM_BUILD_ROOT%{_bindir} -type f | grep -vE "arch|svn|cvs|email|gitk" | sed -e s@^$RPM_BUILD_ROOT@@) > bin-man-doc-files -(find $RPM_BUILD_ROOT%{perl_vendorarch} -type f | sed -e s@^$RPM_BUILD_ROOT@@) >> perl-files +(find $RPM_BUILD_ROOT%{perl_vendorlib} -type f | sed -e s@^$RPM_BUILD_ROOT@@) >> perl-files %if %{!?_without_docs:1}0 (find $RPM_BUILD_ROOT%{_mandir} $RPM_BUILD_ROOT/Documentation -type f | grep -vE "arch|svn|git-cvs|email|gitk" | sed -e s@^$RPM_BUILD_ROOT@@ -e 's/$/*/' ) >> bin-man-doc-files %else -- 1.4.3.rc2.gcc59 ``` ## Josef Weidendorfer, 2006-10-11 12:20 Subject: Re: [RFH] RPM gurus? (Re: rpmbuild fails) Message-ID: <200610111420.25666.Josef.Weidendorfer@gmx.de> URL: https://gitlist.dev/e/200610111420.25666.Josef.Weidendorfer%40gmx.de In-Reply-To: <7vpscztg1c.fsf@assigned-by-dhcp.cox.net> ``` On Wednesday 11 October 2006 10:25, Junio C Hamano wrote: > Does this look reasonable? > > -(find $RPM_BUILD_ROOT%{perl_vendorarch} -type f | sed -e s@^$RPM_BUILD_ROOT@@) >> perl-files > +(find $RPM_BUILD_ROOT%{perl_vendorlib} -type f | sed -e s@^$RPM_BUILD_ROOT@@) >> perl-files That was exactly the modification I did, yes. However, I can only say: It works for me (tm). BTW, this is only Suse 10.1, x86. Josef ```