{"thread":{"id":"5877","subject":"rpmbuild fails","startedAt":"2006-10-10T20:31:49Z","lastAt":"2006-10-11T12:20:25Z","messageCount":5,"participants":["Anders Larsen","Josef Weidendorfer","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"28548","messageId":"pan.2006.10.10.20.31.48.692444@alarsen.net","threadId":"5877","inReplyTo":null,"subject":"rpmbuild fails","fromName":"Anders Larsen","fromEmail":"al@alarsen.net","sentAt":"2006-10-10T20:31:49Z","receivedAt":"2006-10-10T20:31:49Z","isPatch":false,"sender":{"key":"al@alarsen.net","avatar":null},"body":"The current git fails when building rpms:\n\n\tRPM build errors:\n\t Installed (but unpackaged) file(s) found:\n\t /usr/lib/perl5/vendor_perl/5.8.6/Git.pm\n\nIndeed git.spec.in does not specify any files for perl-Git, only\n\t%files -n perl-Git -f perl-files\n\t%defattr(-,root,root)\nnothing more.\n\nHow is this supposed to be handled correctly?\n\nCheers\n Anders\n"},{"id":"28562","messageId":"200610110018.19035.Josef.Weidendorfer@gmx.de","threadId":"5877","inReplyTo":"pan.2006.10.10.20.31.48.692444@alarsen.net","subject":"Re: rpmbuild fails","fromName":"Josef Weidendorfer","fromEmail":"josef.weidendorfer@gmx.de","sentAt":"2006-10-10T22:18:18Z","receivedAt":"2006-10-10T22:18:18Z","isPatch":false,"sender":{"key":"josef.weidendorfer@gmx.de","avatar":null},"body":"On Tuesday 10 October 2006 22:31, Anders Larsen wrote:\n> The current git fails when building rpms:\n> \n> \tRPM build errors:\n> \t Installed (but unpackaged) file(s) found:\n> \t /usr/lib/perl5/vendor_perl/5.8.6/Git.pm\n\nI got the same.\nI'm no rpm guru, but changing %{perl_vendorarch} into\n%{perl_vendorlib} in git.spec.in helped for me.\n\nObviously, the generated perl/Makefile installs Git.pm\ninto the perl vendor *library* directory, and not the arch\none.\n\nI do not provide a real patch, as I have no idea if\nthis is really the correct fix (we have no arch-dependent\nperl files anymore, yes?).\n\nHowever, something like the above should go into git-1.4.3.\n\n> Indeed git.spec.in does not specify any files for perl-Git, only\n> \t%files -n perl-Git -f perl-files\n> \t%defattr(-,root,root)\n> nothing more.\n\nHmm... Obviously the \"... -f perl-files\" includes all files\nmentioned in file \"perl-files\" into perl-Git. The problem was\nthat without the above change this file was empty.\n\nJosef\n"},{"id":"28570","messageId":"7v64erznyj.fsf_-_@assigned-by-dhcp.cox.net","threadId":"5877","inReplyTo":"200610110018.19035.Josef.Weidendorfer@gmx.de","subject":"[RFH] RPM gurus? (Re: rpmbuild fails)","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-10-11T00:38:12Z","receivedAt":"2006-10-11T00:38:12Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Josef Weidendorfer writes:\n\n> On Tuesday 10 October 2006 22:31, Anders Larsen wrote:\n>> The current git fails when building rpms:\n>> \n>> \tRPM build errors:\n>> \t Installed (but unpackaged) file(s) found:\n>> \t /usr/lib/perl5/vendor_perl/5.8.6/Git.pm\n>\n> I got the same.\n> I'm no rpm guru, but changing %{perl_vendorarch} into\n> %{perl_vendorlib} in git.spec.in helped for me.\n>\n> Obviously, the generated perl/Makefile installs Git.pm\n> into the perl vendor *library* directory, and not the arch\n> one.\n\nThanks.\n\nAlso I noticed that we now build-require perl(Error); I have to\nask kernel.org people to install it.\n"},{"id":"28588","messageId":"7vpscztg1c.fsf@assigned-by-dhcp.cox.net","threadId":"5877","inReplyTo":"7v64erznyj.fsf_-_@assigned-by-dhcp.cox.net","subject":"Re: [RFH] RPM gurus? (Re: rpmbuild fails)","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-10-11T08:25:51Z","receivedAt":"2006-10-11T08:25:51Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano writes:\n\n> Josef Weidendorfer writes:\n>\n>> Obviously, the generated perl/Makefile installs Git.pm\n>> into the perl vendor *library* directory, and not the arch\n>> one.\n\nDoes this look reasonable?\n\n-- >8 --\ngit.spec.in: perl subpackage is installed in perl_vendorlib not vendorarch\n\nSigned-off-by: Junio C Hamano \n---\n git.spec.in | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git.spec.in b/git.spec.in\nindex 6d90034..9b1217a 100644\n--- a/git.spec.in\n+++ b/git.spec.in\n@@ -97,7 +97,7 @@ find $RPM_BUILD_ROOT -type f -name '*.bs\n find $RPM_BUILD_ROOT -type f -name perllocal.pod -exec rm -f {} ';'\n \n (find $RPM_BUILD_ROOT%{_bindir} -type f | grep -vE \"arch|svn|cvs|email|gitk\" | sed -e s@^$RPM_BUILD_ROOT@@) > bin-man-doc-files\n-(find $RPM_BUILD_ROOT%{perl_vendorarch} -type f | sed -e s@^$RPM_BUILD_ROOT@@) >> perl-files\n+(find $RPM_BUILD_ROOT%{perl_vendorlib} -type f | sed -e s@^$RPM_BUILD_ROOT@@) >> perl-files\n %if %{!?_without_docs:1}0\n (find $RPM_BUILD_ROOT%{_mandir} $RPM_BUILD_ROOT/Documentation -type f | grep -vE \"arch|svn|git-cvs|email|gitk\" | sed -e s@^$RPM_BUILD_ROOT@@ -e 's/$/*/' ) >> bin-man-doc-files\n %else\n-- \n1.4.3.rc2.gcc59\n"},{"id":"28594","messageId":"200610111420.25666.Josef.Weidendorfer@gmx.de","threadId":"5877","inReplyTo":"7vpscztg1c.fsf@assigned-by-dhcp.cox.net","subject":"Re: [RFH] RPM gurus? (Re: rpmbuild fails)","fromName":"Josef Weidendorfer","fromEmail":"josef.weidendorfer@gmx.de","sentAt":"2006-10-11T12:20:25Z","receivedAt":"2006-10-11T12:20:25Z","isPatch":false,"sender":{"key":"josef.weidendorfer@gmx.de","avatar":null},"body":"On Wednesday 11 October 2006 10:25, Junio C Hamano wrote:\n> Does this look reasonable?\n> \n> -(find $RPM_BUILD_ROOT%{perl_vendorarch} -type f | sed -e s@^$RPM_BUILD_ROOT@@) >> perl-files\n> +(find $RPM_BUILD_ROOT%{perl_vendorlib} -type f | sed -e s@^$RPM_BUILD_ROOT@@) >> perl-files\n\nThat was exactly the modification I did, yes.\nHowever, I can only say: It works for me (tm).\nBTW, this is only Suse 10.1, x86.\n\nJosef\n"}]}