threads / patch / 5720

patchCorrected copy-and-paste thinko in ignore executable bit test case.

Subject: [PATCH] Corrected copy-and-paste thinko in ignore executable bit test case.

## tl;dr

3 messages between Sep 27, 2006 and Sep 27, 2006. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Shawn Pearce· Sep 27, 2006, 15:18 UTC · lore

This test should be testing update-index --add, not git-add as these are two completely different implementations of what is essentially the same task.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 t/t3700-add.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to t/t3700-add.sh +1 −1

diff --git a/t/t3700-add.sh b/t/t3700-add.sh
index d36f22d..c20e4c2 100755
--- a/t/t3700-add.sh
+++ b/t/t3700-add.sh
@@ -35,7 +35,7 @@ test_expect_success \
 	'git repo-config core.filemode 0 &&
 	 echo foo >xfoo2 &&
 	 chmod 755 xfoo2 &&
-	 git-add xfoo2 &&
+	 git-update-index --add xfoo2 &&
 	 case "`git-ls-files --stage xfoo2`" in
 	 100644" "*xfoo2) echo ok;;
 	 *) echo fail; git-ls-files --stage xfoo2; exit 1;;

-- 
1.4.2.1.g1e40

Junio C Hamano· Sep 27, 2006, 19:43 UTC · re: Shawn Pearce · lore

Re: [PATCH] Corrected copy-and-paste thinko in ignore executable bit test case.

Shawn Pearce <spearce@spearce.org> writes:

> This test should be testing update-index --add, not git-add as these
> are two completely different implementations of what is essentially
> the same task.

Thanks -- I'd rephrase the last sentence, though.

Shawn Pearce· Sep 27, 2006, 19:51 UTC · re: Junio C Hamano · lore

Re: [PATCH] Corrected copy-and-paste thinko in ignore executable bit test case.

Junio C Hamano <junkio@cox.net> wrote:

Show 7 quoted lines

> Shawn Pearce <spearce@spearce.org> writes:
> 
> > This test should be testing update-index --add, not git-add as these
> > are two completely different implementations of what is essentially
> > the same task.
> 
> Thanks -- I'd rephrase the last sentence, though.

-- >8 -- Corrected copy-and-paste thinko in ignore executable bit test case.

This test should be testing update-index --add, not git-add to ensure all possible interfaces behave the same way.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 t/t3700-add.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to t/t3700-add.sh +1 −1

diff --git a/t/t3700-add.sh b/t/t3700-add.sh
index d36f22d..c20e4c2 100755
--- a/t/t3700-add.sh
+++ b/t/t3700-add.sh
@@ -35,7 +35,7 @@ test_expect_success \
 	'git repo-config core.filemode 0 &&
 	 echo foo >xfoo2 &&
 	 chmod 755 xfoo2 &&
-	 git-add xfoo2 &&
+	 git-update-index --add xfoo2 &&
 	 case "`git-ls-files --stage xfoo2`" in
 	 100644" "*xfoo2) echo ok;;
 	 *) echo fail; git-ls-files --stage xfoo2; exit 1;;

-- 
1.4.2.1.g1e40