git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Corrected copy-and-paste thinko in ignore executable bit test case.

From
Shawn Pearce <spearce@spearce.org>
Date
Sep 27, 2006, 19:51 UTC
Message-ID
<20060927195113.GA21668@spearce.org>
In-Reply-To
<7vr6xx9jta.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
Show 7 quoted lines
> Shawn Pearce <spearce@spearce.org> writes:
> 
> > This test should be testing update-index --add, not git-add as these
> > are two completely different implementations of what is essentially
> > the same task.
> 
> Thanks -- I'd rephrase the last sentence, though.

-- >8 -- Corrected copy-and-paste thinko in ignore executable bit test case.

This test should be testing update-index --add, not git-add to ensure all possible interfaces behave the same way.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 t/t3700-add.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/t3700-add.sh b/t/t3700-add.sh
index d36f22d..c20e4c2 100755
--- a/t/t3700-add.sh
+++ b/t/t3700-add.sh
@@ -35,7 +35,7 @@ test_expect_success \
 	'git repo-config core.filemode 0 &&
 	 echo foo >xfoo2 &&
 	 chmod 755 xfoo2 &&
-	 git-add xfoo2 &&
+	 git-update-index --add xfoo2 &&
 	 case "`git-ls-files --stage xfoo2`" in
 	 100644" "*xfoo2) echo ok;;
 	 *) echo fail; git-ls-files --stage xfoo2; exit 1;;
-- 
1.4.2.1.g1e40
Previous: Junio C Hamano
Message 3 of 3 in “Corrected copy-and-paste thinko in ignore executable bit test case.”
  1. Corrected copy-and-paste thinko in ignore executable bit test case.Shawn Pearce, Sep 27, 2006
  2. Junio C HamanoSep 27, 2006
  3. Shawn PearceSep 27, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.