{"thread":{"id":"5720","subject":"[PATCH] Corrected copy-and-paste thinko in ignore executable bit test case.","startedAt":"2006-09-27T15:18:49Z","lastAt":"2006-09-27T19:51:13Z","messageCount":3,"participants":["Shawn Pearce","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"27793","messageId":"20060927151849.GF20705@spearce.org","threadId":"5720","inReplyTo":null,"subject":"[PATCH] Corrected copy-and-paste thinko in ignore executable bit test case.","fromName":"Shawn Pearce","fromEmail":"spearce@spearce.org","sentAt":"2006-09-27T15:18:49Z","receivedAt":"2006-09-27T15:18:49Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"This test should be testing update-index --add, not git-add as these\nare two completely different implementations of what is essentially\nthe same task.\n\nSigned-off-by: Shawn O. Pearce <spearce@spearce.org>\n---\n t/t3700-add.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/t/t3700-add.sh b/t/t3700-add.sh\nindex d36f22d..c20e4c2 100755\n--- a/t/t3700-add.sh\n+++ b/t/t3700-add.sh\n@@ -35,7 +35,7 @@ test_expect_success \\\n \t'git repo-config core.filemode 0 &&\n \t echo foo >xfoo2 &&\n \t chmod 755 xfoo2 &&\n-\t git-add xfoo2 &&\n+\t git-update-index --add xfoo2 &&\n \t case \"`git-ls-files --stage xfoo2`\" in\n \t 100644\" \"*xfoo2) echo ok;;\n \t *) echo fail; git-ls-files --stage xfoo2; exit 1;;\n-- \n1.4.2.1.g1e40\n"},{"id":"27810","messageId":"7vr6xx9jta.fsf@assigned-by-dhcp.cox.net","threadId":"5720","inReplyTo":"20060927151849.GF20705@spearce.org","subject":"Re: [PATCH] Corrected copy-and-paste thinko in ignore executable bit test case.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-09-27T19:43:45Z","receivedAt":"2006-09-27T19:43:45Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Shawn Pearce <spearce@spearce.org> writes:\n\n> This test should be testing update-index --add, not git-add as these\n> are two completely different implementations of what is essentially\n> the same task.\n\nThanks -- I'd rephrase the last sentence, though.\n"},{"id":"27811","messageId":"20060927195113.GA21668@spearce.org","threadId":"5720","inReplyTo":"7vr6xx9jta.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Corrected copy-and-paste thinko in ignore executable bit test case.","fromName":"Shawn Pearce","fromEmail":"spearce@spearce.org","sentAt":"2006-09-27T19:51:13Z","receivedAt":"2006-09-27T19:51:13Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Junio C Hamano <junkio@cox.net> wrote:\n> Shawn Pearce <spearce@spearce.org> writes:\n> \n> > This test should be testing update-index --add, not git-add as these\n> > are two completely different implementations of what is essentially\n> > the same task.\n> \n> Thanks -- I'd rephrase the last sentence, though.\n\n-- >8 --\nCorrected copy-and-paste thinko in ignore executable bit test case.\n\nThis test should be testing update-index --add, not git-add to\nensure all possible interfaces behave the same way.\n\nSigned-off-by: Shawn O. Pearce <spearce@spearce.org>\n---\n t/t3700-add.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/t/t3700-add.sh b/t/t3700-add.sh\nindex d36f22d..c20e4c2 100755\n--- a/t/t3700-add.sh\n+++ b/t/t3700-add.sh\n@@ -35,7 +35,7 @@ test_expect_success \\\n \t'git repo-config core.filemode 0 &&\n \t echo foo >xfoo2 &&\n \t chmod 755 xfoo2 &&\n-\t git-add xfoo2 &&\n+\t git-update-index --add xfoo2 &&\n \t case \"`git-ls-files --stage xfoo2`\" in\n \t 100644\" \"*xfoo2) echo ok;;\n \t *) echo fail; git-ls-files --stage xfoo2; exit 1;;\n-- \n1.4.2.1.g1e40\n"}]}