[PATCH] Makefile: remove redundant GIT-CFLAGS dependency from "sparse"

Ævar Arnfjörð Bjarmason· Oct 21, 2021, 20:00 UTC · lore

The "sparse" target needed the GIT-CFLAGS dependency before my c234e8a0ecf (Makefile: make the "sparse" target non-.PHONY, 2021-09-23), but since then it depends on the corresponding *.o files, which in turn depend on the correct header files, as well as on GIT-CFLAGS. There's no need to re-state this dependency here.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
A tiny redundancy fix for an already-in-master topic.

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to Makefile +1 −1

diff --git a/Makefile b/Makefile
index 381bed2c1d2..12be39ac497 100644
--- a/Makefile
+++ b/Makefile
@@ -2901,7 +2901,7 @@ check-sha1:: t/helper/test-tool$X
 
 SP_OBJ = $(patsubst %.o,%.sp,$(C_OBJ))
 
-$(SP_OBJ): %.sp: %.c %.o GIT-CFLAGS
+$(SP_OBJ): %.sp: %.c %.o
 	$(QUIET_SP)cgcc -no-compile $(ALL_CFLAGS) $(EXTRA_CPPFLAGS) \
 		-Wsparse-error \
 		$(SPARSE_FLAGS) $(SP_EXTRA_FLAGS) $< && \

-- 
2.33.1.1494.g88b39a443e1

Johannes Schindelin· Oct 22, 2021, 14:30 UTC · re: Ævar Arnfjörð Bjarmason · lore

Re: [PATCH] Makefile: remove redundant GIT-CFLAGS dependency from "sparse"

Hi Ævar,

On Thu, 21 Oct 2021, Ævar Arnfjörð Bjarmason wrote:

Show 23 quoted lines

> The "sparse" target needed the GIT-CFLAGS dependency before my
> c234e8a0ecf (Makefile: make the "sparse" target non-.PHONY,
> 2021-09-23), but since then it depends on the corresponding *.o files,
> which in turn depend on the correct header files, as well as on
> GIT-CFLAGS. There's no need to re-state this dependency here.
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
> A tiny redundancy fix for an already-in-master topic.
>
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 381bed2c1d2..12be39ac497 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2901,7 +2901,7 @@ check-sha1:: t/helper/test-tool$X
>
>  SP_OBJ = $(patsubst %.o,%.sp,$(C_OBJ))
>
> -$(SP_OBJ): %.sp: %.c %.o GIT-CFLAGS
> +$(SP_OBJ): %.sp: %.c %.o

I _guess_ you could say that the `GIT-CFLAGS` dependency is redundant by virtue of the `*.o` targets already depending on it.

But then, how much does it hurt? This late in the v2.34 cycle, aren't there any issues that might be worthier of our attention and care?

Ciao, Dscho

Show 7 quoted lines

>  	$(QUIET_SP)cgcc -no-compile $(ALL_CFLAGS) $(EXTRA_CPPFLAGS) \
>  		-Wsparse-error \
>  		$(SPARSE_FLAGS) $(SP_EXTRA_FLAGS) $< && \
> --
> 2.33.1.1494.g88b39a443e1
>
>

patchMakefile: remove redundant GIT-CFLAGS dependency from "sparse"