{"thread":{"id":"56752","subject":"[PATCH] Makefile: remove redundant GIT-CFLAGS dependency from \"sparse\"","startedAt":"2021-10-21T20:00:20Z","lastAt":"2021-10-22T14:30:17Z","messageCount":2,"participants":["Ævar Arnfjörð Bjarmason","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"439278","messageId":"patch-1.1-207f1019e70-20211021T195940Z-avarab@gmail.com","threadId":"56752","inReplyTo":null,"subject":"[PATCH] Makefile: remove redundant GIT-CFLAGS dependency from \"sparse\"","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-10-21T20:00:14Z","receivedAt":"2021-10-21T20:00:20Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"The \"sparse\" target needed the GIT-CFLAGS dependency before my\nc234e8a0ecf (Makefile: make the \"sparse\" target non-.PHONY,\n2021-09-23), but since then it depends on the corresponding *.o files,\nwhich in turn depend on the correct header files, as well as on\nGIT-CFLAGS. There's no need to re-state this dependency here.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\nA tiny redundancy fix for an already-in-master topic.\n\n Makefile | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Makefile b/Makefile\nindex 381bed2c1d2..12be39ac497 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -2901,7 +2901,7 @@ check-sha1:: t/helper/test-tool$X\n \n SP_OBJ = $(patsubst %.o,%.sp,$(C_OBJ))\n \n-$(SP_OBJ): %.sp: %.c %.o GIT-CFLAGS\n+$(SP_OBJ): %.sp: %.c %.o\n \t$(QUIET_SP)cgcc -no-compile $(ALL_CFLAGS) $(EXTRA_CPPFLAGS) \\\n \t\t-Wsparse-error \\\n \t\t$(SPARSE_FLAGS) $(SP_EXTRA_FLAGS) $< && \\\n-- \n2.33.1.1494.g88b39a443e1\n\n"},{"id":"439377","messageId":"nycvar.QRO.7.76.6.2110221628190.62@tvgsbejvaqbjf.bet","threadId":"56752","inReplyTo":"patch-1.1-207f1019e70-20211021T195940Z-avarab@gmail.com","subject":"Re: [PATCH] Makefile: remove redundant GIT-CFLAGS dependency from \"sparse\"","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2021-10-22T14:30:08Z","receivedAt":"2021-10-22T14:30:17Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Ævar,\n\nOn Thu, 21 Oct 2021, Ævar Arnfjörð Bjarmason wrote:\n\n> The \"sparse\" target needed the GIT-CFLAGS dependency before my\n> c234e8a0ecf (Makefile: make the \"sparse\" target non-.PHONY,\n> 2021-09-23), but since then it depends on the corresponding *.o files,\n> which in turn depend on the correct header files, as well as on\n> GIT-CFLAGS. There's no need to re-state this dependency here.\n>\n> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n> ---\n> A tiny redundancy fix for an already-in-master topic.\n>\n>  Makefile | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Makefile b/Makefile\n> index 381bed2c1d2..12be39ac497 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -2901,7 +2901,7 @@ check-sha1:: t/helper/test-tool$X\n>\n>  SP_OBJ = $(patsubst %.o,%.sp,$(C_OBJ))\n>\n> -$(SP_OBJ): %.sp: %.c %.o GIT-CFLAGS\n> +$(SP_OBJ): %.sp: %.c %.o\n\nI _guess_ you could say that the `GIT-CFLAGS` dependency is redundant by\nvirtue of the `*.o` targets already depending on it.\n\nBut then, how much does it hurt? This late in the v2.34 cycle, aren't\nthere any issues that might be worthier of our attention and care?\n\nCiao,\nDscho\n\n>  \t$(QUIET_SP)cgcc -no-compile $(ALL_CFLAGS) $(EXTRA_CPPFLAGS) \\\n>  \t\t-Wsparse-error \\\n>  \t\t$(SPARSE_FLAGS) $(SP_EXTRA_FLAGS) $< && \\\n> --\n> 2.33.1.1494.g88b39a443e1\n>\n>\n"}]}