git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Makefile: remove redundant GIT-CFLAGS dependency from "sparse"

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Oct 21, 2021, 20:00 UTC
Message-ID
<patch-1.1-207f1019e70-20211021T195940Z-avarab@gmail.com>

The "sparse" target needed the GIT-CFLAGS dependency before my c234e8a0ecf (Makefile: make the "sparse" target non-.PHONY, 2021-09-23), but since then it depends on the corresponding *.o files, which in turn depend on the correct header files, as well as on GIT-CFLAGS. There's no need to re-state this dependency here.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
A tiny redundancy fix for an already-in-master topic.
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 381bed2c1d2..12be39ac497 100644
--- a/Makefile
+++ b/Makefile
@@ -2901,7 +2901,7 @@ check-sha1:: t/helper/test-tool$X
 
 SP_OBJ = $(patsubst %.o,%.sp,$(C_OBJ))
 
-$(SP_OBJ): %.sp: %.c %.o GIT-CFLAGS
+$(SP_OBJ): %.sp: %.c %.o
 	$(QUIET_SP)cgcc -no-compile $(ALL_CFLAGS) $(EXTRA_CPPFLAGS) \
 		-Wsparse-error \
 		$(SPARSE_FLAGS) $(SP_EXTRA_FLAGS) $< && \
-- 
2.33.1.1494.g88b39a443e1
Next: Johannes Schindelin
Message 1 of 2 in “Makefile: remove redundant GIT-CFLAGS dependency from "sparse"”
  1. Makefile: remove redundant GIT-CFLAGS dependency from "sparse"Ævar Arnfjörð Bjarmason, Oct 21, 2021
  2. Johannes SchindelinOct 22, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.