threads / patch / 5652

patchFix snapshot link in tree view

Subject: [PATCH] Fix snapshot link in tree view

## tl;dr

4 messages between Sep 22, 2006 and Sep 23, 2006. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Petr Baudis· Sep 22, 2006, 23:21 UTC · lore

It would just give HEAD snapshot instead of one of the particular tree.

Perhaps we should also include snapshot in the global navbar? And perhaps stgit should have a way to edit the mail before sending it so that I could note this below the three dashes? ;-)

Signed-off-by: Petr Baudis <pasky@suse.cz>
---

 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to gitweb/gitweb.perl +1 −1

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index c5f3810..fc31ac3 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2771,7 +2771,7 @@ sub git_tree {
 		if ($have_snapshot) {
 			# FIXME: Should be available when we have no hash base as well.
 			push @views_nav,
-				$cgi->a({-href => href(action=>"snapshot")},
+				$cgi->a({-href => href(action=>"snapshot", hash=>$hash)},
 					"snapshot");
 		}
 		git_print_page_nav('tree','', $hash_base, undef, undef, join(' | ', @views_nav));

Junio C Hamano· Sep 23, 2006, 00:44 UTC · re: Petr Baudis · lore

Re: [PATCH] Fix snapshot link in tree view

Petr Baudis <pasky@suse.cz> writes:

Show 5 quoted lines

> It would just give HEAD snapshot instead of one of the particular tree.
>
> Perhaps we should also include snapshot in the global navbar? And perhaps
> stgit should have a way to edit the mail before sending it so that I could
> note this below the three dashes? ;-)

Personally, I do not mind having the first "Perhaps" in the log message.

Will apply.

Jakub Narebski· Sep 23, 2006, 09:01 UTC · re: Petr Baudis · lore

Re: [PATCH] Fix snapshot link in tree view

By the way, using "[PATCH] gitweb: Fix snapshot link in tree view" would make this patch easier to read as gitweb patch.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

Petr Baudis· Sep 23, 2006, 12:16 UTC · re: Jakub Narebski · lore

Re: [PATCH] Fix snapshot link in tree view

Dear diary, on Sat, Sep 23, 2006 at 11:01:15AM CEST, I got a letter where Jakub Narebski <jnareb@gmail.com> said that...

> By the way, using "[PATCH] gitweb: Fix snapshot link in tree view" would
> make this patch easier to read as gitweb patch.

Sorry, I try to mark those patches as gitweb but sometimes I forget. :-)

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)