{"thread":{"id":"5652","subject":"[PATCH] Fix snapshot link in tree view","startedAt":"2006-09-22T23:21:20Z","lastAt":"2006-09-23T12:16:45Z","messageCount":4,"participants":["Petr Baudis","Junio C Hamano","Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"27427","messageId":"20060922232120.596.63045.stgit@rover","threadId":"5652","inReplyTo":null,"subject":"[PATCH] Fix snapshot link in tree view","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2006-09-22T23:21:20Z","receivedAt":"2006-09-22T23:21:20Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"It would just give HEAD snapshot instead of one of the particular tree.\n\nPerhaps we should also include snapshot in the global navbar? And perhaps\nstgit should have a way to edit the mail before sending it so that I could\nnote this below the three dashes? ;-)\n\nSigned-off-by: Petr Baudis <pasky@suse.cz>\n---\n\n gitweb/gitweb.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex c5f3810..fc31ac3 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -2771,7 +2771,7 @@ sub git_tree {\n \t\tif ($have_snapshot) {\n \t\t\t# FIXME: Should be available when we have no hash base as well.\n \t\t\tpush @views_nav,\n-\t\t\t\t$cgi->a({-href => href(action=>\"snapshot\")},\n+\t\t\t\t$cgi->a({-href => href(action=>\"snapshot\", hash=>$hash)},\n \t\t\t\t\t\"snapshot\");\n \t\t}\n \t\tgit_print_page_nav('tree','', $hash_base, undef, undef, join(' | ', @views_nav));\n"},{"id":"27431","messageId":"7virjfxvgt.fsf@assigned-by-dhcp.cox.net","threadId":"5652","inReplyTo":"20060922232120.596.63045.stgit@rover","subject":"Re: [PATCH] Fix snapshot link in tree view","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-09-23T00:44:34Z","receivedAt":"2006-09-23T00:44:34Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Petr Baudis <pasky@suse.cz> writes:\n\n> It would just give HEAD snapshot instead of one of the particular tree.\n>\n> Perhaps we should also include snapshot in the global navbar? And perhaps\n> stgit should have a way to edit the mail before sending it so that I could\n> note this below the three dashes? ;-)\n\nPersonally, I do not mind having the first \"Perhaps\" in the log\nmessage.\n\nWill apply.\n"},{"id":"27457","messageId":"ef2t4n$bcp$3@sea.gmane.org","threadId":"5652","inReplyTo":"20060922232120.596.63045.stgit@rover","subject":"Re: [PATCH] Fix snapshot link in tree view","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-09-23T09:01:15Z","receivedAt":"2006-09-23T09:01:15Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"By the way, using \"[PATCH] gitweb: Fix snapshot link in tree view\" would\nmake this patch easier to read as gitweb patch.\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"27468","messageId":"20060923121645.GI8259@pasky.or.cz","threadId":"5652","inReplyTo":"ef2t4n$bcp$3@sea.gmane.org","subject":"Re: [PATCH] Fix snapshot link in tree view","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2006-09-23T12:16:45Z","receivedAt":"2006-09-23T12:16:45Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Sat, Sep 23, 2006 at 11:01:15AM CEST, I got a letter\nwhere Jakub Narebski <jnareb@gmail.com> said that...\n> By the way, using \"[PATCH] gitweb: Fix snapshot link in tree view\" would\n> make this patch easier to read as gitweb patch.\n\nSorry, I try to mark those patches as gitweb but sometimes I forget. :-)\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\n#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj\n$/=unpack('H*',$_);$_=`echo 16dio\\U$k\"SK$/SM$n\\EsN0p[lN*1\nlK[d2%Sa2/d0$^Ixp\"|dc`;s/\\W//g;$_=pack('H*',/((..)*)$/)\n"}]}