# [PATCH] Fix snapshot link in tree view

4 messages from 2006-09-22 to 2006-09-23. Participants: Petr Baudis, Junio C Hamano, Jakub Narebski.
Thread: https://gitlist.dev/t/5652

## Petr Baudis, 2006-09-22 23:21

Subject: [PATCH] Fix snapshot link in tree view
Message-ID: <20060922232120.596.63045.stgit@rover>
URL: https://gitlist.dev/e/20060922232120.596.63045.stgit%40rover

```
It would just give HEAD snapshot instead of one of the particular tree.

Perhaps we should also include snapshot in the global navbar? And perhaps
stgit should have a way to edit the mail before sending it so that I could
note this below the three dashes? ;-)

Signed-off-by: Petr Baudis <pasky@suse.cz>
---

 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index c5f3810..fc31ac3 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2771,7 +2771,7 @@ sub git_tree {
 		if ($have_snapshot) {
 			# FIXME: Should be available when we have no hash base as well.
 			push @views_nav,
-				$cgi->a({-href => href(action=>"snapshot")},
+				$cgi->a({-href => href(action=>"snapshot", hash=>$hash)},
 					"snapshot");
 		}
 		git_print_page_nav('tree','', $hash_base, undef, undef, join(' | ', @views_nav));

```

## Junio C Hamano, 2006-09-23 00:44

Subject: Re: [PATCH] Fix snapshot link in tree view
Message-ID: <7virjfxvgt.fsf@assigned-by-dhcp.cox.net>
URL: https://gitlist.dev/e/7virjfxvgt.fsf%40assigned-by-dhcp.cox.net
In-Reply-To: <20060922232120.596.63045.stgit@rover>

```
Petr Baudis <pasky@suse.cz> writes:

> It would just give HEAD snapshot instead of one of the particular tree.
>
> Perhaps we should also include snapshot in the global navbar? And perhaps
> stgit should have a way to edit the mail before sending it so that I could
> note this below the three dashes? ;-)

Personally, I do not mind having the first "Perhaps" in the log
message.

Will apply.

```

## Jakub Narebski, 2006-09-23 09:01

Subject: Re: [PATCH] Fix snapshot link in tree view
Message-ID: <ef2t4n$bcp$3@sea.gmane.org>
URL: https://gitlist.dev/e/ef2t4n%24bcp%243%40sea.gmane.org
In-Reply-To: <20060922232120.596.63045.stgit@rover>

```
By the way, using "[PATCH] gitweb: Fix snapshot link in tree view" would
make this patch easier to read as gitweb patch.
-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

```

## Petr Baudis, 2006-09-23 12:16

Subject: Re: [PATCH] Fix snapshot link in tree view
Message-ID: <20060923121645.GI8259@pasky.or.cz>
URL: https://gitlist.dev/e/20060923121645.GI8259%40pasky.or.cz
In-Reply-To: <ef2t4n$bcp$3@sea.gmane.org>

```
Dear diary, on Sat, Sep 23, 2006 at 11:01:15AM CEST, I got a letter
where Jakub Narebski <jnareb@gmail.com> said that...
> By the way, using "[PATCH] gitweb: Fix snapshot link in tree view" would
> make this patch easier to read as gitweb patch.

Sorry, I try to mark those patches as gitweb but sometimes I forget. :-)

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)

```