threads / discuss / 56231

Problems with Git's Spanish translation

Subject: Problems with Git's Spanish translation

## tl;dr

5 messages between Aug 7, 2021 and Aug 9, 2021.

replies: 4people: 3as markdown or json

Alex Henrie· Aug 7, 2021, 05:10 UTC · lore

Hello,

There are a large number of mistakes in Git's Spanish translation. Most of the mistakes are just typos, but in some cases the translations are incorrect to the point of incomprehensibility. I sent a pull request to the Spanish translation's maintainer in June,[1] but received no reply on GitHub. When I emailed the maintainer directly, he replied that he had little time for reviewing changes.

May I send these changes to Jiang Xin directly?

-Alex

[1] https://github.com/ChrisADR/git-po/pull/22

Carlo Arenas· Aug 7, 2021, 06:12 UTC · re: Alex Henrie · lore

Re: Problems with Git's Spanish translation

your last version has over 5K changes and from those almost 10% seem to be missing from the original, so my guess would be this is indeed not something that could be reviewed in time for the next release (currently in rc1) AS-IS.

Before I gave up, I noticed there were indeed some where the original text was too mangled to be readable, so maybe focus on those first to make the patch more easy to digest and to get those fixes for the release.

Some of the other ones might be added on top as independent commits grouped in common cases (ex: the ones adding/removing spaces, or the ones where a specific term has been renamed) so the full list is more manageable IMHO, and might even get enough reviews to be included sooner than later.

Carlo

PS. for example one of the first changes does ("aplicar stash" -> "hacer stash") for "stash" which make more sense than the direct translation "esconder" in this context, especially considering the command is called "stash" anyway, but that seem more of a personal preference and definitely could wait, unlike others. having that (and similar changes) on its own patch allows for a discussion and prioritization without holding the more important changes.

Alex Henrie· Aug 7, 2021, 06:29 UTC · re: Carlo Arenas · lore

Re: Problems with Git's Spanish translation

On Sat, Aug 7, 2021 at 12:12 AM Carlo Arenas <carenas@gmail.com> wrote:

Show 5 quoted lines

>
> your last version has over 5K changes and from those almost 10% seem
> to be missing from the original, so my guess would be this is indeed
> not something that could be reviewed in time for the next release
> (currently in rc1) AS-IS.

I just rebased the patch to make sure that it doesn't include any changes that have already been made upstream.

Show 10 quoted lines

> Before I gave up, I noticed there were indeed some where the original
> text was too mangled to be readable, so maybe focus on those first to
> make the patch more easy to digest and to get those fixes for the
> release.
>
> Some of the other ones might be added on top as independent commits
> grouped in common cases (ex: the ones adding/removing spaces, or the
> ones where a specific term has been renamed) so the full list is more
> manageable IMHO, and might even get enough reviews to be included
> sooner than later.

If that's what it takes, I'll do it, but others have submitted tiny pull requests at https://github.com/ChrisADR/git-po/pulls and they have been ignored too.

Show 7 quoted lines

> PS. for example one of the first changes does ("aplicar stash" ->
> "hacer stash") for "stash" which make more sense than the direct
> translation "esconder" in this context, especially considering the
> command is called "stash" anyway, but that seem more of a personal
> preference and definitely could wait, unlike others.  having that (and
> similar changes) on its own patch allows for a discussion and
> prioritization without holding the more important changes.

"aplicar stash" literally means "apply stash", but this is incorrect: The command runs `git stash`, not `git stash apply`. That's why I changed it; it has nothing to do with personal preference.

-Alex

Alex Henrie· Aug 7, 2021, 16:00 UTC · lore

Re: Problems with Git's Spanish translation

On Sat, Aug 7, 2021 at 6:17 AM Christopher Díaz Riveros <christopher.diaz.riv@gmail.com> wrote:

>
> Just as an fyi, as Carlo mentioned, the window for updates is the moment when I make some time to review patches (not currently a full time developer nor translator)...

Nor am I, but I have some time to work on this. Please let me help by trusting that I'm not going to totally screw it up.

> Some come through PRs and others directly through email, and sometimes, as Carlo mentioned I have over 5k lines to review in a single commit, so I have to pick some of the most important changes and apply them directly in another commit,

5,000 lines might seem like a lot, but I didn't even attempt to harmonize the terminology in the translation. For example, the translation still uses a mix of "tú" and "usted" (although some work was done previously to try to standardize on "tú"), and many terms like "amend" and "bundle" are sometimes translated and sometimes left in English.

> and those PRs are the easy ones because there are others which have over 100 commits from development branches not even related to localization...

You can reduce the displayed diff on GitHub in an instant by fast-forwarding <https://github.com/ChrisADR/git-po> to <https://github.com/git-l10n/git-po>.

> Sometimes the commiter adds extra changes trying to fix "Spanish correctness" according to their country... Which makes the diffs bigger and harder to read... And those same correctness changes are then "fixed" in another commit by another person...

In my opinion, the "generic" Spanish translation (which is the only Spanish translation we have at the moment) should avoid using words that can have different meanings in different countries. If I've made changes that seem to just change from one dialect to another, this is why. And if you want me to drop any of the changes, just note them on GitHub and I will. Right now I'm just trying to fix things that are not controversial.

> That being said, thanks for taking the time to review and propose changes, I'll try to review and pick the most important ones for this release candidate :)

You're welcome!

-Alex

Jiang Xin· Aug 9, 2021, 04:42 UTC · re: Alex Henrie · lore

Re: Problems with Git's Spanish translation

Alex Henrie <alexhenrie24@gmail.com> 于2021年8月8日周日 上午12:00写道：

>
> You can reduce the displayed diff on GitHub in an instant by
> fast-forwarding <https://github.com/ChrisADR/git-po> to
> <https://github.com/git-l10n/git-po>.

By using a specific diff driver, diff of your patch may be reduced from 5k to 1k lines. You can define custom diff driver by adding new git config and setting attributes for ".po" files. See files in:

    https://github.com/git-l10n/git-po-helper/tree/master/contrib/diff-dirver

Show 9 quoted lines

> > Sometimes the commiter adds extra changes trying to fix "Spanish correctness" according to their country... Which makes the diffs bigger and harder to read... And those same correctness changes are then "fixed" in another commit by another person...
>
> In my opinion, the "generic" Spanish translation (which is the only
> Spanish translation we have at the moment) should avoid using words
> that can have different meanings in different countries. If I've made
> changes that seem to just change from one dialect to another, this is
> why. And if you want me to drop any of the changes, just note them on
> GitHub and I will. Right now I'm just trying to fix things that are
> not controversial.

Some languages have variants, such as "po/zh_CN.po" and "po/zh_TW.po" for Chinese language. I wonder "po/es.po" should be rename as "po/es_ES.po" like "po/pt_PT.po", so that language variants for Latin American can use their own po files.

-- Jiang Xin