{"thread":{"id":"56231","subject":"Problems with Git's Spanish translation","startedAt":"2021-08-07T05:10:36Z","lastAt":"2021-08-09T04:42:43Z","messageCount":5,"participants":["Alex Henrie","Carlo Arenas","Jiang Xin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"432226","messageId":"CAMMLpeR8C_gjZ0CE8-nEo7syt=t0MwMGVKw8BL0k_BTpsk2D5Q@mail.gmail.com","threadId":"56231","inReplyTo":null,"subject":"Problems with Git's Spanish translation","fromName":"Alex Henrie","fromEmail":"alexhenrie24@gmail.com","sentAt":"2021-08-07T05:10:20Z","receivedAt":"2021-08-07T05:10:36Z","isPatch":false,"sender":{"key":"alexhenrie24@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5951993?v=4"},"body":"Hello,\n\nThere are a large number of mistakes in Git's Spanish translation.\nMost of the mistakes are just typos, but in some cases the\ntranslations are incorrect to the point of incomprehensibility. I sent\na pull request to the Spanish translation's maintainer in June,[1] but\nreceived no reply on GitHub. When I emailed the maintainer directly,\nhe replied that he had little time for reviewing changes.\n\nMay I send these changes to Jiang Xin directly?\n\n-Alex\n\n[1] https://github.com/ChrisADR/git-po/pull/22\n"},{"id":"432227","messageId":"CAPUEspik6iGd2X5tOCwvo+FNmcoipy1KGvfgNJd2KLu9-XS7Yw@mail.gmail.com","threadId":"56231","inReplyTo":"CAMMLpeR8C_gjZ0CE8-nEo7syt=t0MwMGVKw8BL0k_BTpsk2D5Q@mail.gmail.com","subject":"Re: Problems with Git's Spanish translation","fromName":"Carlo Arenas","fromEmail":"carenas@gmail.com","sentAt":"2021-08-07T06:12:25Z","receivedAt":"2021-08-07T06:12:42Z","isPatch":false,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"your last version has over 5K changes and from those almost 10% seem\nto be missing from the original, so my guess would be this is indeed\nnot something that could be reviewed in time for the next release\n(currently in rc1) AS-IS.\n\nBefore I gave up, I noticed there were indeed some where the original\ntext was too mangled to be readable, so maybe focus on those first to\nmake the patch more easy to digest and to get those fixes for the\nrelease.\n\nSome of the other ones might be added on top as independent commits\ngrouped in common cases (ex: the ones adding/removing spaces, or the\nones where a specific term has been renamed) so the full list is more\nmanageable IMHO, and might even get enough reviews to be included\nsooner than later.\n\nCarlo\n\nPS. for example one of the first changes does (\"aplicar stash\" ->\n\"hacer stash\") for \"stash\" which make more sense than the direct\ntranslation \"esconder\" in this context, especially considering the\ncommand is called \"stash\" anyway, but that seem more of a personal\npreference and definitely could wait, unlike others. having that (and\nsimilar changes) on its own patch allows for a discussion and\nprioritization without holding the more important changes.\n"},{"id":"432229","messageId":"CAMMLpeRDLxRfskKV0+S2CHTNVTnFgfO1K_sGQy_v6DXrA5JGcQ@mail.gmail.com","threadId":"56231","inReplyTo":"CAPUEspik6iGd2X5tOCwvo+FNmcoipy1KGvfgNJd2KLu9-XS7Yw@mail.gmail.com","subject":"Re: Problems with Git's Spanish translation","fromName":"Alex Henrie","fromEmail":"alexhenrie24@gmail.com","sentAt":"2021-08-07T06:29:51Z","receivedAt":"2021-08-07T06:30:42Z","isPatch":false,"sender":{"key":"alexhenrie24@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5951993?v=4"},"body":"On Sat, Aug 7, 2021 at 12:12 AM Carlo Arenas wrote:\n>\n> your last version has over 5K changes and from those almost 10% seem\n> to be missing from the original, so my guess would be this is indeed\n> not something that could be reviewed in time for the next release\n> (currently in rc1) AS-IS.\n\nI just rebased the patch to make sure that it doesn't include any\nchanges that have already been made upstream.\n\n> Before I gave up, I noticed there were indeed some where the original\n> text was too mangled to be readable, so maybe focus on those first to\n> make the patch more easy to digest and to get those fixes for the\n> release.\n>\n> Some of the other ones might be added on top as independent commits\n> grouped in common cases (ex: the ones adding/removing spaces, or the\n> ones where a specific term has been renamed) so the full list is more\n> manageable IMHO, and might even get enough reviews to be included\n> sooner than later.\n\nIf that's what it takes, I'll do it, but others have submitted tiny\npull requests at https://github.com/ChrisADR/git-po/pulls and they\nhave been ignored too.\n\n> PS. for example one of the first changes does (\"aplicar stash\" ->\n> \"hacer stash\") for \"stash\" which make more sense than the direct\n> translation \"esconder\" in this context, especially considering the\n> command is called \"stash\" anyway, but that seem more of a personal\n> preference and definitely could wait, unlike others. having that (and\n> similar changes) on its own patch allows for a discussion and\n> prioritization without holding the more important changes.\n\n\"aplicar stash\" literally means \"apply stash\", but this is incorrect:\nThe command runs `git stash`, not `git stash apply`. That's why I\nchanged it; it has nothing to do with personal preference.\n\n-Alex\n"},{"id":"432250","messageId":"CAMMLpeQmbT-YmK3RrhPwe1bs8KNkEztony0QtbzoSbgNYjH3zA@mail.gmail.com","threadId":"56231","inReplyTo":"CAHCo6sqi0WmxxKMU=Nx=z_3PDx84YmUOa+ACRcBbM=R_nr4nrg@mail.gmail.com","subject":"Re: Problems with Git's Spanish translation","fromName":"Alex Henrie","fromEmail":"alexhenrie24@gmail.com","sentAt":"2021-08-07T16:00:32Z","receivedAt":"2021-08-07T16:00:49Z","isPatch":false,"sender":{"key":"alexhenrie24@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5951993?v=4"},"body":"On Sat, Aug 7, 2021 at 6:17 AM Christopher Díaz Riveros\n wrote:\n>\n> Just as an fyi, as Carlo mentioned, the window for updates is the moment when I make some time to review patches (not currently a full time developer nor translator)...\n\nNor am I, but I have some time to work on this. Please let me help by\ntrusting that I'm not going to totally screw it up.\n\n> Some come through PRs and others directly through email, and sometimes, as Carlo mentioned I have over 5k lines to review in a single commit, so I have to pick some of the most important changes and apply them directly in another commit,\n\n5,000 lines might seem like a lot, but I didn't even attempt to\nharmonize the terminology in the translation. For example, the\ntranslation still uses a mix of \"tú\" and \"usted\" (although some work\nwas done previously to try to standardize on \"tú\"), and many terms\nlike \"amend\" and \"bundle\" are sometimes translated and sometimes left\nin English.\n\n> and those PRs are the easy ones because there are others which have over 100 commits from development branches not even related to localization...\n\nYou can reduce the displayed diff on GitHub in an instant by\nfast-forwarding to\n.\n\n> Sometimes the commiter adds extra changes trying to fix \"Spanish correctness\" according to their country... Which makes the diffs bigger and harder to read... And those same correctness changes are then \"fixed\" in another commit by another person...\n\nIn my opinion, the \"generic\" Spanish translation (which is the only\nSpanish translation we have at the moment) should avoid using words\nthat can have different meanings in different countries. If I've made\nchanges that seem to just change from one dialect to another, this is\nwhy. And if you want me to drop any of the changes, just note them on\nGitHub and I will. Right now I'm just trying to fix things that are\nnot controversial.\n\n> That being said, thanks for taking the time to review and propose changes, I'll try to review and pick the most important ones for this release candidate :)\n\nYou're welcome!\n\n-Alex\n"},{"id":"432284","messageId":"CANYiYbGWc7_e+9FLX0_JnLfp2652TrK12gg6hQXc2eyB7KEnpg@mail.gmail.com","threadId":"56231","inReplyTo":"CAMMLpeQmbT-YmK3RrhPwe1bs8KNkEztony0QtbzoSbgNYjH3zA@mail.gmail.com","subject":"Re: Problems with Git's Spanish translation","fromName":"Jiang Xin","fromEmail":"worldhello.net@gmail.com","sentAt":"2021-08-09T04:42:20Z","receivedAt":"2021-08-09T04:42:43Z","isPatch":false,"sender":{"key":"worldhello.net@gmail.com","avatar":"https://avatars.githubusercontent.com/u/183860?v=4"},"body":"Alex Henrie 于2021年8月8日周日 上午12:00写道：\n>\n> You can reduce the displayed diff on GitHub in an instant by\n> fast-forwarding to\n> .\n\nBy using a specific diff driver, diff of your patch may be reduced\nfrom 5k to 1k lines. You can define custom diff driver by adding new\ngit config and setting attributes for \".po\" files. See files in:\n\n https://github.com/git-l10n/git-po-helper/tree/master/contrib/diff-dirver\n\n> > Sometimes the commiter adds extra changes trying to fix \"Spanish correctness\" according to their country... Which makes the diffs bigger and harder to read... And those same correctness changes are then \"fixed\" in another commit by another person...\n>\n> In my opinion, the \"generic\" Spanish translation (which is the only\n> Spanish translation we have at the moment) should avoid using words\n> that can have different meanings in different countries. If I've made\n> changes that seem to just change from one dialect to another, this is\n> why. And if you want me to drop any of the changes, just note them on\n> GitHub and I will. Right now I'm just trying to fix things that are\n> not controversial.\n\nSome languages have variants, such as \"po/zh_CN.po\" and \"po/zh_TW.po\"\nfor Chinese language. I wonder \"po/es.po\" should be rename as\n\"po/es_ES.po\" like \"po/pt_PT.po\", so that language variants for Latin\nAmerican can use their own po files.\n\n--\nJiang Xin\n"}]}