threads / patch / 55706

patchsubmodule: use the imperative mood to describe the --files option

Subject: [PATCH] submodule: use the imperative mood to describe the --files option

## tl;dr

3 messages between May 16, 2021 and May 17, 2021. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Alex Henrie· May 16, 2021, 21:59 UTC · lore

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
---
 builtin/submodule--helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to builtin/submodule--helper.c +1 −1

diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index d55f6262e9..ae6174ab05 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -1300,7 +1300,7 @@ static int module_summary(int argc, const char **argv, const char *prefix)
 		OPT_BOOL(0, "cached", &cached,
 			 N_("use the commit stored in the index instead of the submodule HEAD")),
 		OPT_BOOL(0, "files", &files,
-			 N_("to compare the commit in the index with that in the submodule HEAD")),
+			 N_("compare the commit in the index with that in the submodule HEAD")),
 		OPT_BOOL(0, "for-status", &for_status,
 			 N_("skip submodules with 'ignore_config' value set to 'all'")),
 		OPT_INTEGER('n', "summary-limit", &summary_limit,

-- 
2.31.1

Bagas Sanjaya· May 17, 2021, 05:58 UTC · re: Alex Henrie · lore

Re: [PATCH] submodule: use the imperative mood to describe the --files option

Hi Alex,

On 17/05/21 04.59, Alex Henrie wrote:

> -			 N_("to compare the commit in the index with that in the submodule HEAD")),
> +			 N_("compare the commit in the index with that in the submodule HEAD")),

Seems correct.

FYI, on my native language (Indonesian), we say "Review yourself" as "Tinjau dirimu" for imperative mood. Unfortunately many imperative sentences on software l10n instead prefix the verb with "me-", such as "meninjau dirimu". That is not imperative mood; that is descriptive mood with infinitive verb form.

Anyway, thanks.

Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>

-- 
An old man doll... just what I always wanted! - Clara

Junio C Hamano· May 17, 2021, 06:56 UTC · re: Alex Henrie · lore

Re: [PATCH] submodule: use the imperative mood to describe the --files option

Alex Henrie <alexhenrie24@gmail.com> writes:

Show 18 quoted lines

> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> ---
>  builtin/submodule--helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> index d55f6262e9..ae6174ab05 100644
> --- a/builtin/submodule--helper.c
> +++ b/builtin/submodule--helper.c
> @@ -1300,7 +1300,7 @@ static int module_summary(int argc, const char **argv, const char *prefix)
>  		OPT_BOOL(0, "cached", &cached,
>  			 N_("use the commit stored in the index instead of the submodule HEAD")),
>  		OPT_BOOL(0, "files", &files,
> -			 N_("to compare the commit in the index with that in the submodule HEAD")),
> +			 N_("compare the commit in the index with that in the submodule HEAD")),
>  		OPT_BOOL(0, "for-status", &for_status,
>  			 N_("skip submodules with 'ignore_config' value set to 'all'")),
>  		OPT_INTEGER('n', "summary-limit", &summary_limit,

Unlike many other helper functions in this file, this one is likely to survive when the remainder of "git submodule" scripted Porcelain is rewritten in C, so it is a good idea to update it with this patch.

Thanks, will queue.