git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] submodule: use the imperative mood to describe the --files option

From
Junio C Hamano <gitster@pobox.com>
Date
May 17, 2021, 06:56 UTC
Message-ID
<xmqqmtst3l31.fsf@gitster.g>
In-Reply-To
<20210516215957.33341-1-alexhenrie24@gmail.com>
Alex Henrie <alexhenrie24@gmail.com> writes:
Show 18 quoted lines
> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> ---
>  builtin/submodule--helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> index d55f6262e9..ae6174ab05 100644
> --- a/builtin/submodule--helper.c
> +++ b/builtin/submodule--helper.c
> @@ -1300,7 +1300,7 @@ static int module_summary(int argc, const char **argv, const char *prefix)
>  		OPT_BOOL(0, "cached", &cached,
>  			 N_("use the commit stored in the index instead of the submodule HEAD")),
>  		OPT_BOOL(0, "files", &files,
> -			 N_("to compare the commit in the index with that in the submodule HEAD")),
> +			 N_("compare the commit in the index with that in the submodule HEAD")),
>  		OPT_BOOL(0, "for-status", &for_status,
>  			 N_("skip submodules with 'ignore_config' value set to 'all'")),
>  		OPT_INTEGER('n', "summary-limit", &summary_limit,

Unlike many other helper functions in this file, this one is likely to survive when the remainder of "git submodule" scripted Porcelain is rewritten in C, so it is a good idea to update it with this patch.

Thanks, will queue.
Previous: Bagas Sanjaya
Message 3 of 3 in “submodule: use the imperative mood to describe the --files option”
  1. submodule: use the imperative mood to describe the --files optionAlex Henrie, May 16, 2021
  2. Bagas SanjayaMay 17, 2021
  3. Junio C HamanoMay 17, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.