{"thread":{"id":"55706","subject":"[PATCH] submodule: use the imperative mood to describe the --files option","startedAt":"2021-05-16T22:00:14Z","lastAt":"2021-05-17T06:56:06Z","messageCount":3,"participants":["Alex Henrie","Bagas Sanjaya","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"424694","messageId":"20210516215957.33341-1-alexhenrie24@gmail.com","threadId":"55706","inReplyTo":null,"subject":"[PATCH] submodule: use the imperative mood to describe the --files option","fromName":"Alex Henrie","fromEmail":"alexhenrie24@gmail.com","sentAt":"2021-05-16T21:59:57Z","receivedAt":"2021-05-16T22:00:14Z","isPatch":true,"sender":{"key":"alexhenrie24@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5951993?v=4"},"body":"Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>\n---\n builtin/submodule--helper.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c\nindex d55f6262e9..ae6174ab05 100644\n--- a/builtin/submodule--helper.c\n+++ b/builtin/submodule--helper.c\n@@ -1300,7 +1300,7 @@ static int module_summary(int argc, const char **argv, const char *prefix)\n \t\tOPT_BOOL(0, \"cached\", &cached,\n \t\t\t N_(\"use the commit stored in the index instead of the submodule HEAD\")),\n \t\tOPT_BOOL(0, \"files\", &files,\n-\t\t\t N_(\"to compare the commit in the index with that in the submodule HEAD\")),\n+\t\t\t N_(\"compare the commit in the index with that in the submodule HEAD\")),\n \t\tOPT_BOOL(0, \"for-status\", &for_status,\n \t\t\t N_(\"skip submodules with 'ignore_config' value set to 'all'\")),\n \t\tOPT_INTEGER('n', \"summary-limit\", &summary_limit,\n-- \n2.31.1\n\n"},{"id":"424700","messageId":"1cfb25fd-1ef9-864c-bbb3-bab0a5676728@gmail.com","threadId":"55706","inReplyTo":"20210516215957.33341-1-alexhenrie24@gmail.com","subject":"Re: [PATCH] submodule: use the imperative mood to describe the --files option","fromName":"Bagas Sanjaya","fromEmail":"bagasdotme@gmail.com","sentAt":"2021-05-17T05:58:03Z","receivedAt":"2021-05-17T05:58:15Z","isPatch":true,"sender":{"key":"bagasdotme@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40219486?v=4"},"body":"Hi Alex,\n\nOn 17/05/21 04.59, Alex Henrie wrote:\n> -\t\t\t N_(\"to compare the commit in the index with that in the submodule HEAD\")),\n> +\t\t\t N_(\"compare the commit in the index with that in the submodule HEAD\")),\n\nSeems correct.\n\nFYI, on my native language (Indonesian), we say \"Review yourself\" as\n\"Tinjau dirimu\" for imperative mood. Unfortunately many imperative\nsentences on software l10n instead prefix the verb with \"me-\", such as\n\"meninjau dirimu\". That is not imperative mood; that is descriptive\nmood with infinitive verb form.\n\nAnyway, thanks.\n\nReviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>\n\n-- \nAn old man doll... just what I always wanted! - Clara\n"},{"id":"424706","messageId":"xmqqmtst3l31.fsf@gitster.g","threadId":"55706","inReplyTo":"20210516215957.33341-1-alexhenrie24@gmail.com","subject":"Re: [PATCH] submodule: use the imperative mood to describe the --files option","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-05-17T06:56:02Z","receivedAt":"2021-05-17T06:56:06Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Alex Henrie <alexhenrie24@gmail.com> writes:\n\n> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>\n> ---\n>  builtin/submodule--helper.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c\n> index d55f6262e9..ae6174ab05 100644\n> --- a/builtin/submodule--helper.c\n> +++ b/builtin/submodule--helper.c\n> @@ -1300,7 +1300,7 @@ static int module_summary(int argc, const char **argv, const char *prefix)\n>  \t\tOPT_BOOL(0, \"cached\", &cached,\n>  \t\t\t N_(\"use the commit stored in the index instead of the submodule HEAD\")),\n>  \t\tOPT_BOOL(0, \"files\", &files,\n> -\t\t\t N_(\"to compare the commit in the index with that in the submodule HEAD\")),\n> +\t\t\t N_(\"compare the commit in the index with that in the submodule HEAD\")),\n>  \t\tOPT_BOOL(0, \"for-status\", &for_status,\n>  \t\t\t N_(\"skip submodules with 'ignore_config' value set to 'all'\")),\n>  \t\tOPT_INTEGER('n', \"summary-limit\", &summary_limit,\n\nUnlike many other helper functions in this file, this one is likely\nto survive when the remainder of \"git submodule\" scripted Porcelain\nis rewritten in C, so it is a good idea to update it with this\npatch.\n\nThanks, will queue.\n"}]}