threads / patch / 55438

patchtest-bloom: fix missing 'bloom' from usage string

Subject: [PATCH] test-bloom: fix missing 'bloom' from usage string

## tl;dr

2 messages between Apr 6, 2021 and Apr 6, 2021. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Christian Couder· Apr 6, 2021, 02:35 UTC · lore

Like 'get_murmur3' and 'generate_filter', 'get_filter_for_commit' is a subcommand of `test-tool bloom` not of `test-tool` itself.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 t/helper/test-bloom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to t/helper/test-bloom.c +1 −1

diff --git a/t/helper/test-bloom.c b/t/helper/test-bloom.c
index 2a1ae3dae6..ad3ef1cd77 100644
--- a/t/helper/test-bloom.c
+++ b/t/helper/test-bloom.c
@@ -48,7 +48,7 @@ static void get_bloom_filter_for_commit(const struct object_id *commit_oid)
 static const char *bloom_usage = "\n"
 "  test-tool bloom get_murmur3 <string>\n"
 "  test-tool bloom generate_filter <string> [<string>...]\n"
-"  test-tool get_filter_for_commit <commit-hex>\n";
+"  test-tool bloom get_filter_for_commit <commit-hex>\n";
 
 int cmd__bloom(int argc, const char **argv)
 {

-- 
2.31.1.189.g2e36527f23

Derrick Stolee· Apr 6, 2021, 13:05 UTC · re: Christian Couder · lore

Re: [PATCH] test-bloom: fix missing 'bloom' from usage string

On 4/5/2021 10:35 PM, Christian Couder wrote:

Show 18 quoted lines

> Like 'get_murmur3' and 'generate_filter', 'get_filter_for_commit' is a
> subcommand of `test-tool bloom` not of `test-tool` itself.
> 
> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
>  t/helper/test-bloom.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/t/helper/test-bloom.c b/t/helper/test-bloom.c
> index 2a1ae3dae6..ad3ef1cd77 100644
> --- a/t/helper/test-bloom.c
> +++ b/t/helper/test-bloom.c
> @@ -48,7 +48,7 @@ static void get_bloom_filter_for_commit(const struct object_id *commit_oid)
>  static const char *bloom_usage = "\n"
>  "  test-tool bloom get_murmur3 <string>\n"
>  "  test-tool bloom generate_filter <string> [<string>...]\n"
> -"  test-tool get_filter_for_commit <commit-hex>\n";
> +"  test-tool bloom get_filter_for_commit <commit-hex>\n";

Obviously correct. Good find.

Thanks, -Stolee