git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] test-bloom: fix missing 'bloom' from usage string

From
Derrick Stolee <stolee@gmail.com>
Date
Apr 6, 2021, 13:05 UTC
Message-ID
<149395c6-1c68-cf8b-2322-e62b0e48c652@gmail.com>
In-Reply-To
<20210406023514.27060-1-chriscool@tuxfamily.org>
On 4/5/2021 10:35 PM, Christian Couder wrote:
Show 18 quoted lines
> Like 'get_murmur3' and 'generate_filter', 'get_filter_for_commit' is a
> subcommand of `test-tool bloom` not of `test-tool` itself.
> 
> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
>  t/helper/test-bloom.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/t/helper/test-bloom.c b/t/helper/test-bloom.c
> index 2a1ae3dae6..ad3ef1cd77 100644
> --- a/t/helper/test-bloom.c
> +++ b/t/helper/test-bloom.c
> @@ -48,7 +48,7 @@ static void get_bloom_filter_for_commit(const struct object_id *commit_oid)
>  static const char *bloom_usage = "\n"
>  "  test-tool bloom get_murmur3 <string>\n"
>  "  test-tool bloom generate_filter <string> [<string>...]\n"
> -"  test-tool get_filter_for_commit <commit-hex>\n";
> +"  test-tool bloom get_filter_for_commit <commit-hex>\n";
Obviously correct. Good find.

Thanks, -Stolee

Previous: Christian Couder
Message 2 of 2 in “test-bloom: fix missing 'bloom' from usage string”
  1. test-bloom: fix missing 'bloom' from usage stringChristian Couder, Apr 6, 2021
  2. Derrick StoleeApr 6, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.