{"thread":{"id":"55438","subject":"[PATCH] test-bloom: fix missing 'bloom' from usage string","startedAt":"2021-04-06T02:35:40Z","lastAt":"2021-04-06T13:05:15Z","messageCount":2,"participants":["Christian Couder","Derrick Stolee"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"421035","messageId":"20210406023514.27060-1-chriscool@tuxfamily.org","threadId":"55438","inReplyTo":null,"subject":"[PATCH] test-bloom: fix missing 'bloom' from usage string","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2021-04-06T02:35:14Z","receivedAt":"2021-04-06T02:35:40Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Like 'get_murmur3' and 'generate_filter', 'get_filter_for_commit' is a\nsubcommand of `test-tool bloom` not of `test-tool` itself.\n\nSigned-off-by: Christian Couder <chriscool@tuxfamily.org>\n---\n t/helper/test-bloom.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/helper/test-bloom.c b/t/helper/test-bloom.c\nindex 2a1ae3dae6..ad3ef1cd77 100644\n--- a/t/helper/test-bloom.c\n+++ b/t/helper/test-bloom.c\n@@ -48,7 +48,7 @@ static void get_bloom_filter_for_commit(const struct object_id *commit_oid)\n static const char *bloom_usage = \"\\n\"\n \"  test-tool bloom get_murmur3 <string>\\n\"\n \"  test-tool bloom generate_filter <string> [<string>...]\\n\"\n-\"  test-tool get_filter_for_commit <commit-hex>\\n\";\n+\"  test-tool bloom get_filter_for_commit <commit-hex>\\n\";\n \n int cmd__bloom(int argc, const char **argv)\n {\n-- \n2.31.1.189.g2e36527f23\n\n"},{"id":"421061","messageId":"149395c6-1c68-cf8b-2322-e62b0e48c652@gmail.com","threadId":"55438","inReplyTo":"20210406023514.27060-1-chriscool@tuxfamily.org","subject":"Re: [PATCH] test-bloom: fix missing 'bloom' from usage string","fromName":"Derrick Stolee","fromEmail":"stolee@gmail.com","sentAt":"2021-04-06T13:05:09Z","receivedAt":"2021-04-06T13:05:15Z","isPatch":true,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"On 4/5/2021 10:35 PM, Christian Couder wrote:\n> Like 'get_murmur3' and 'generate_filter', 'get_filter_for_commit' is a\n> subcommand of `test-tool bloom` not of `test-tool` itself.\n> \n> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>\n> ---\n>  t/helper/test-bloom.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/t/helper/test-bloom.c b/t/helper/test-bloom.c\n> index 2a1ae3dae6..ad3ef1cd77 100644\n> --- a/t/helper/test-bloom.c\n> +++ b/t/helper/test-bloom.c\n> @@ -48,7 +48,7 @@ static void get_bloom_filter_for_commit(const struct object_id *commit_oid)\n>  static const char *bloom_usage = \"\\n\"\n>  \"  test-tool bloom get_murmur3 <string>\\n\"\n>  \"  test-tool bloom generate_filter <string> [<string>...]\\n\"\n> -\"  test-tool get_filter_for_commit <commit-hex>\\n\";\n> +\"  test-tool bloom get_filter_for_commit <commit-hex>\\n\";\n\nObviously correct. Good find.\n\nThanks,\n-Stolee\n"}]}