threads / patch / 55377

patch, 2 partstransport.c: modify comment in transport_get().

Subject: [PATCH 1/2] transport.c: modify comment in transport_get().

## tl;dr

3 messages between Mar 24, 2021 and Mar 25, 2021. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

lilinchao@oschina.cn· Mar 24, 2021, 05:36 UTC · lore

From: lilinchao <lilinchao@oschina.cn>

Signed-off-by: lilinchao <lilinchao@oschina.cn>
---
 transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to transport.c +1 −1

diff --git a/transport.c b/transport.c
index 1c4ab676d1..71b3d44cf3 100644
--- a/transport.c
+++ b/transport.c
@@ -1078,7 +1078,7 @@ struct transport *transport_get(struct remote *remote, const char *url)
 		data->conn = NULL;
 		data->got_remote_heads = 0;
 	} else {
-		/* Unknown protocol in URL. Pass to external handler. */
+		/* Http/https and other unknown protocol in URL. Pass to external handler. */
 		int len = external_specification_len(url);
 		char *handler = xmemdupz(url, len);
 		transport_helper_init(ret, handler);

-- 
2.30.0.1006.g4a81e96670

Junio C Hamano· Mar 24, 2021, 20:23 UTC · re: lilinchao@oschina.cn · lore

Re: [PATCH 1/2] transport.c: modify comment in transport_get().

lilinchao@oschina.cn writes:

Show 17 quoted lines

> From: lilinchao <lilinchao@oschina.cn>
>
> Signed-off-by: lilinchao <lilinchao@oschina.cn>
> ---
>  transport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/transport.c b/transport.c
> index 1c4ab676d1..71b3d44cf3 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -1078,7 +1078,7 @@ struct transport *transport_get(struct remote *remote, const char *url)
>  		data->conn = NULL;
>  		data->got_remote_heads = 0;
>  	} else {
> -		/* Unknown protocol in URL. Pass to external handler. */
> +		/* Http/https and other unknown protocol in URL. Pass to external handler. */

The previous block says

		/*
		 * These are builtin smart transports; "allowed" transports
		 * will be checked individually in git_connect.
		 */

where it lists file:// git:// and ssh:// URLs. And contrasting with that, it should be clear "unknown" refers to "not a builtin that is known to the C code linked to the same binary" and includes http:// and https://.

IOW, I am not sure adding "http/https and other" to make it an overlong line is worth doing.

Thanks.

lilinchao@oschina.cn· Mar 25, 2021, 03:39 UTC · lore

Re: Re: [PATCH 1/2] transport.c: modify comment in transport_get().

Show 32 quoted lines

>lilinchao@oschina.cn writes:
>
>> From: lilinchao <lilinchao@oschina.cn>
>>
>> Signed-off-by: lilinchao <lilinchao@oschina.cn>
>> ---
>>  transport.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/transport.c b/transport.c
>> index 1c4ab676d1..71b3d44cf3 100644
>> --- a/transport.c
>> +++ b/transport.c
>> @@ -1078,7 +1078,7 @@ struct transport *transport_get(struct remote *remote, const char *url)
>>  data->conn = NULL;
>>  data->got_remote_heads = 0;
>>  } else {
>> -	/* Unknown protocol in URL. Pass to external handler. */
>> +	/* Http/https and other unknown protocol in URL. Pass to external handler. */
>
>The previous block says
>
>	/*
>	* These are builtin smart transports; "allowed" transports
>	* will be checked individually in git_connect.
>	*/
>
>where it lists file:// git:// and ssh:// URLs.  And contrasting with
>that, it should be clear "unknown" refers to "not a builtin that is
>known to the C code linked to the same binary" and includes http://
>and https://.
>

I think the comment here should explicitly mention that HTTP is included :)

>IOW, I am not sure adding "http/https and other" to make it an
>overlong line is worth doing.
>

Indeed, overlong line is not good, I will drop this change.

>Thanks.