# [PATCH 1/2] transport.c: modify comment in transport_get(). 3 messages from 2021-03-24 to 2021-03-25. Participants: lilinchao@oschina.cn, Junio C Hamano. Thread: https://gitlist.dev/t/55377 ## lilinchao@oschina.cn, 2021-03-24 05:36 Subject: [PATCH 1/2] transport.c: modify comment in transport_get(). Message-ID: URL: https://gitlist.dev/e/f64df5f88c6211eb9c9a0024e87935e7%40oschina.cn ``` From: lilinchao Signed-off-by: lilinchao --- transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/transport.c b/transport.c index 1c4ab676d1..71b3d44cf3 100644 --- a/transport.c +++ b/transport.c @@ -1078,7 +1078,7 @@ struct transport *transport_get(struct remote *remote, const char *url) data->conn = NULL; data->got_remote_heads = 0; } else { - /* Unknown protocol in URL. Pass to external handler. */ + /* Http/https and other unknown protocol in URL. Pass to external handler. */ int len = external_specification_len(url); char *handler = xmemdupz(url, len); transport_helper_init(ret, handler); -- 2.30.0.1006.g4a81e96670 ``` ## Junio C Hamano, 2021-03-24 20:23 Subject: Re: [PATCH 1/2] transport.c: modify comment in transport_get(). Message-ID: URL: https://gitlist.dev/e/xmqqblb8xpw1.fsf%40gitster.g In-Reply-To: ``` lilinchao@oschina.cn writes: > From: lilinchao > > Signed-off-by: lilinchao > --- > transport.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/transport.c b/transport.c > index 1c4ab676d1..71b3d44cf3 100644 > --- a/transport.c > +++ b/transport.c > @@ -1078,7 +1078,7 @@ struct transport *transport_get(struct remote *remote, const char *url) > data->conn = NULL; > data->got_remote_heads = 0; > } else { > - /* Unknown protocol in URL. Pass to external handler. */ > + /* Http/https and other unknown protocol in URL. Pass to external handler. */ The previous block says /* * These are builtin smart transports; "allowed" transports * will be checked individually in git_connect. */ where it lists file:// git:// and ssh:// URLs. And contrasting with that, it should be clear "unknown" refers to "not a builtin that is known to the C code linked to the same binary" and includes http:// and https://. IOW, I am not sure adding "http/https and other" to make it an overlong line is worth doing. Thanks. ``` ## lilinchao@oschina.cn, 2021-03-25 03:39 Subject: Re: Re: [PATCH 1/2] transport.c: modify comment in transport_get(). Message-ID: URL: https://gitlist.dev/e/a46828308d1b11eb8d710026b95c99cc%40oschina.cn In-Reply-To: ``` >lilinchao@oschina.cn writes: > >> From: lilinchao >> >> Signed-off-by: lilinchao >> --- >>  transport.c | 2 +- >>  1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/transport.c b/transport.c >> index 1c4ab676d1..71b3d44cf3 100644 >> --- a/transport.c >> +++ b/transport.c >> @@ -1078,7 +1078,7 @@ struct transport *transport_get(struct remote *remote, const char *url) >>  data->conn = NULL; >>  data->got_remote_heads = 0; >>  } else { >> - /* Unknown protocol in URL. Pass to external handler. */ >> + /* Http/https and other unknown protocol in URL. Pass to external handler. */ > >The previous block says > > /* > * These are builtin smart transports; "allowed" transports > * will be checked individually in git_connect. > */ > >where it lists file:// git:// and ssh:// URLs.  And contrasting with >that, it should be clear "unknown" refers to "not a builtin that is >known to the C code linked to the same binary" and includes http:// >and https://. > I think the comment here should explicitly mention that HTTP is included :) >IOW, I am not sure adding "http/https and other" to make it an >overlong line is worth doing. > Indeed, overlong line is not good, I will drop this change. >Thanks. ```