{"thread":{"id":"55377","subject":"[PATCH 1/2] transport.c: modify comment in transport_get().","startedAt":"2021-03-24T05:38:10Z","lastAt":"2021-03-25T03:39:47Z","messageCount":3,"participants":["lilinchao@oschina.cn","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"420103","messageId":"f64df5f88c6211eb9c9a0024e87935e7@oschina.cn","threadId":"55377","inReplyTo":null,"subject":"[PATCH 1/2] transport.c: modify comment in transport_get().","fromName":"","fromEmail":"lilinchao@oschina.cn","sentAt":"2021-03-24T05:36:47Z","receivedAt":"2021-03-24T05:38:10Z","isPatch":true,"sender":{"key":"lilinchao@oschina.cn","avatar":null},"body":"From: lilinchao <lilinchao@oschina.cn>\n\nSigned-off-by: lilinchao <lilinchao@oschina.cn>\n---\n transport.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/transport.c b/transport.c\nindex 1c4ab676d1..71b3d44cf3 100644\n--- a/transport.c\n+++ b/transport.c\n@@ -1078,7 +1078,7 @@ struct transport *transport_get(struct remote *remote, const char *url)\n \t\tdata->conn = NULL;\n \t\tdata->got_remote_heads = 0;\n \t} else {\n-\t\t/* Unknown protocol in URL. Pass to external handler. */\n+\t\t/* Http/https and other unknown protocol in URL. Pass to external handler. */\n \t\tint len = external_specification_len(url);\n \t\tchar *handler = xmemdupz(url, len);\n \t\ttransport_helper_init(ret, handler);\n-- \n2.30.0.1006.g4a81e96670\n\n"},{"id":"420144","messageId":"xmqqblb8xpw1.fsf@gitster.g","threadId":"55377","inReplyTo":"f64df5f88c6211eb9c9a0024e87935e7@oschina.cn","subject":"Re: [PATCH 1/2] transport.c: modify comment in transport_get().","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-03-24T20:23:10Z","receivedAt":"2021-03-24T20:23:53Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"lilinchao@oschina.cn writes:\n\n> From: lilinchao <lilinchao@oschina.cn>\n>\n> Signed-off-by: lilinchao <lilinchao@oschina.cn>\n> ---\n>  transport.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/transport.c b/transport.c\n> index 1c4ab676d1..71b3d44cf3 100644\n> --- a/transport.c\n> +++ b/transport.c\n> @@ -1078,7 +1078,7 @@ struct transport *transport_get(struct remote *remote, const char *url)\n>  \t\tdata->conn = NULL;\n>  \t\tdata->got_remote_heads = 0;\n>  \t} else {\n> -\t\t/* Unknown protocol in URL. Pass to external handler. */\n> +\t\t/* Http/https and other unknown protocol in URL. Pass to external handler. */\n\nThe previous block says\n\n\t\t/*\n\t\t * These are builtin smart transports; \"allowed\" transports\n\t\t * will be checked individually in git_connect.\n\t\t */\n\nwhere it lists file:// git:// and ssh:// URLs.  And contrasting with\nthat, it should be clear \"unknown\" refers to \"not a builtin that is\nknown to the C code linked to the same binary\" and includes http://\nand https://.\n\nIOW, I am not sure adding \"http/https and other\" to make it an\noverlong line is worth doing.\n\nThanks.\n"},{"id":"420174","messageId":"a46828308d1b11eb8d710026b95c99cc@oschina.cn","threadId":"55377","inReplyTo":"c6ee6c9e8cde11eba7e5a4badb2c2b1175929@pobox.com","subject":"Re: Re: [PATCH 1/2] transport.c: modify comment in transport_get().","fromName":"lilinchao@oschina.cn","fromEmail":"lilinchao@oschina.cn","sentAt":"2021-03-25T03:39:01Z","receivedAt":"2021-03-25T03:39:47Z","isPatch":true,"sender":{"key":"lilinchao@oschina.cn","avatar":null},"body":">lilinchao@oschina.cn writes:\n>\n>> From: lilinchao <lilinchao@oschina.cn>\n>>\n>> Signed-off-by: lilinchao <lilinchao@oschina.cn>\n>> ---\n>>  transport.c | 2 +-\n>>  1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/transport.c b/transport.c\n>> index 1c4ab676d1..71b3d44cf3 100644\n>> --- a/transport.c\n>> +++ b/transport.c\n>> @@ -1078,7 +1078,7 @@ struct transport *transport_get(struct remote *remote, const char *url)\n>>  data->conn = NULL;\n>>  data->got_remote_heads = 0;\n>>  } else {\n>> -\t/* Unknown protocol in URL. Pass to external handler. */\n>> +\t/* Http/https and other unknown protocol in URL. Pass to external handler. */\n>\n>The previous block says\n>\n>\t/*\n>\t* These are builtin smart transports; \"allowed\" transports\n>\t* will be checked individually in git_connect.\n>\t*/\n>\n>where it lists file:// git:// and ssh:// URLs.  And contrasting with\n>that, it should be clear \"unknown\" refers to \"not a builtin that is\n>known to the C code linked to the same binary\" and includes http://\n>and https://.\n> \n\nI think the comment here should explicitly mention that HTTP\nis included :)\n\n>IOW, I am not sure adding \"http/https and other\" to make it an\n>overlong line is worth doing.\n> \n\nIndeed, overlong line is not good, I will drop this change.\n\n>Thanks."}]}