threads / patch / 54181

patchvcbuild: fix library name for expat with make MSVC=1

Subject: [PATCH] vcbuild: fix library name for expat with make MSVC=1

## tl;dr

4 messages between Sep 2, 2020 and Sep 3, 2020. Diffs are folded; open one to read it.

replies: 3people: 4as markdown or json

Orgad Shaneh via GitGitGadget· Sep 2, 2020, 20:16 UTC · lore
From: Orgad Shaneh <orgads@gmail.com>
Signed-off-by: Orgad Shaneh <orgads@gmail.com>
---
    vcbuild: fix library name for expat with make MSVC=1
    
    Signed-off-by: Orgad Shaneh orgads@gmail.com [orgads@gmail.com]
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-722%2Forgads%2Fvcbuild-expat-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-722/orgads/vcbuild-expat-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/722
 compat/vcbuild/scripts/clink.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to compat/vcbuild/scripts/clink.pl +1 −1
diff --git a/compat/vcbuild/scripts/clink.pl b/compat/vcbuild/scripts/clink.pl
index 61ad084a7b..df167d1e1a 100755
--- a/compat/vcbuild/scripts/clink.pl
+++ b/compat/vcbuild/scripts/clink.pl
@@ -66,7 +66,7 @@
 		}
 		push(@args, $lib);
 	} elsif ("$arg" eq "-lexpat") {
-		push(@args, "expat.lib");
+		push(@args, "libexpat.lib");
 	} elsif ("$arg" =~ /^-L/ && "$arg" ne "-LTCG") {
 		$arg =~ s/^-L/-LIBPATH:/;
 		push(@lflags, $arg);

base-commit: e19713638985533ce461db072b49112da5bd2042

-- 
gitgitgadget
Jonathan Nieder· Sep 3, 2020, 00:06 UTC · re: Orgad Shaneh via GitGitGadget · lore

Re: [PATCH] vcbuild: fix library name for expat with make MSVC=1

(cc-ing a couple of Windows experts) Orgad Shaneh wrote:

> Subject: vcbuild: fix library name for expat with make MSVC=1

Do you have more details? For example, what error message does the build produce without this change?

Show 8 quoted lines
> Signed-off-by: Orgad Shaneh <orgads@gmail.com>
> ---
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-722%2Forgads%2Fvcbuild-expat-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-722/orgads/vcbuild-expat-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/722
>
>  compat/vcbuild/scripts/clink.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I'm ignorant enough about the platform-specific details involved that I'd like an Ack from one of the Windows folks.

Thanks, Jonathan

Show 17 quoted lines
> diff --git a/compat/vcbuild/scripts/clink.pl b/compat/vcbuild/scripts/clink.pl
> index 61ad084a7b..df167d1e1a 100755
> --- a/compat/vcbuild/scripts/clink.pl
> +++ b/compat/vcbuild/scripts/clink.pl
> @@ -66,7 +66,7 @@
>  		}
>  		push(@args, $lib);
>  	} elsif ("$arg" eq "-lexpat") {
> -		push(@args, "expat.lib");
> +		push(@args, "libexpat.lib");
>  	} elsif ("$arg" =~ /^-L/ && "$arg" ne "-LTCG") {
>  		$arg =~ s/^-L/-LIBPATH:/;
>  		push(@lflags, $arg);
> 
> base-commit: e19713638985533ce461db072b49112da5bd2042
> -- 
> gitgitgadget
Junio C Hamano· Sep 3, 2020, 02:07 UTC · re: Jonathan Nieder · lore

Re: [PATCH] vcbuild: fix library name for expat with make MSVC=1

Jonathan Nieder <jrnieder@gmail.com> writes:
Show 7 quoted lines
> (cc-ing a couple of Windows experts)
> Orgad Shaneh wrote:
>
>> Subject: vcbuild: fix library name for expat with make MSVC=1
>
> Do you have more details?  For example, what error message does the
> build produce without this change?

Presumably you'd get an error at link time, saying either 'no such library: expat.lib', or 'symbol X not found' for symbols that were supposed to come from libexpat.lib.

I do not think we want to see exact error message. If an empty body of the log message bothers us, I probably would say that it is sufficient to write something like

    The name of the expat library is libexpat.lib, not expat.lib;
    otherwise we'd get linkage errors.
> I'm ignorant enough about the platform-specific details involved that
> I'd like an Ack from one of the Windows folks.

I saw Dscho looked at both pull requests and commented on them, but haven't seen him (or anybody else) acking or nacking the version that was submitted. It would be nice to see an Ack from Windows' side.

Thanks.
Johannes Schindelin· Sep 3, 2020, 01:42 UTC · re: Orgad Shaneh via GitGitGadget · lore

Re: [PATCH] vcbuild: fix library name for expat with make MSVC=1

Hi Orgad,
On Wed, 2 Sep 2020, Orgad Shaneh via GitGitGadget wrote:
Show 7 quoted lines
> From: Orgad Shaneh <orgads@gmail.com>
>
> Signed-off-by: Orgad Shaneh <orgads@gmail.com>
> ---
>     vcbuild: fix library name for expat with make MSVC=1
>
>     Signed-off-by: Orgad Shaneh orgads@gmail.com [orgads@gmail.com]

As can be seen at https://dev.azure.com/git/git/_build/results?buildId=2065&view=artifacts&type=publishedArtifacts, this change is correct.

ACK.

Thank you, Dscho

Show 26 quoted lines
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-722%2Forgads%2Fvcbuild-expat-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-722/orgads/vcbuild-expat-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/722
>
>  compat/vcbuild/scripts/clink.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/compat/vcbuild/scripts/clink.pl b/compat/vcbuild/scripts/clink.pl
> index 61ad084a7b..df167d1e1a 100755
> --- a/compat/vcbuild/scripts/clink.pl
> +++ b/compat/vcbuild/scripts/clink.pl
> @@ -66,7 +66,7 @@
>  		}
>  		push(@args, $lib);
>  	} elsif ("$arg" eq "-lexpat") {
> -		push(@args, "expat.lib");
> +		push(@args, "libexpat.lib");
>  	} elsif ("$arg" =~ /^-L/ && "$arg" ne "-LTCG") {
>  		$arg =~ s/^-L/-LIBPATH:/;
>  		push(@lflags, $arg);
>
> base-commit: e19713638985533ce461db072b49112da5bd2042
> --
> gitgitgadget
>

← back to recent threads