Re: [PATCH] vcbuild: fix library name for expat with make MSVC=1

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 3, 2020, 02:07 UTC
Message-ID: <xmqqk0xba9zr.fsf@gitster.c.googlers.com>
In-Reply-To: <20200903000640.GD4035286@google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 7 quoted lines

> (cc-ing a couple of Windows experts)
> Orgad Shaneh wrote:
>
>> Subject: vcbuild: fix library name for expat with make MSVC=1
>
> Do you have more details?  For example, what error message does the
> build produce without this change?

Presumably you'd get an error at link time, saying either 'no such library: expat.lib', or 'symbol X not found' for symbols that were supposed to come from libexpat.lib.

I do not think we want to see exact error message. If an empty body of the log message bothers us, I probably would say that it is sufficient to write something like

    The name of the expat library is libexpat.lib, not expat.lib;
    otherwise we'd get linkage errors.

> I'm ignorant enough about the platform-specific details involved that
> I'd like an Ack from one of the Windows folks.

I saw Dscho looked at both pull requests and commented on them, but haven't seen him (or anybody else) acking or nacking the version that was submitted. It would be nice to see an Ack from Windows' side.

Thanks.