{"thread":{"id":"54181","subject":"[PATCH] vcbuild: fix library name for expat with make MSVC=1","startedAt":"2020-09-02T20:16:43Z","lastAt":"2020-09-03T10:06:47Z","messageCount":4,"participants":["Orgad Shaneh via GitGitGadget","Jonathan Nieder","Junio C Hamano","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"404937","messageId":"pull.722.git.1599077798953.gitgitgadget@gmail.com","threadId":"54181","inReplyTo":null,"subject":"[PATCH] vcbuild: fix library name for expat with make MSVC=1","fromName":"Orgad Shaneh via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2020-09-02T20:16:38Z","receivedAt":"2020-09-02T20:16:43Z","isPatch":true,"sender":{"key":"orgads@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1246544?v=4"},"body":"From: Orgad Shaneh <orgads@gmail.com>\n\nSigned-off-by: Orgad Shaneh <orgads@gmail.com>\n---\n    vcbuild: fix library name for expat with make MSVC=1\n    \n    Signed-off-by: Orgad Shaneh orgads@gmail.com [orgads@gmail.com]\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-722%2Forgads%2Fvcbuild-expat-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-722/orgads/vcbuild-expat-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/722\n\n compat/vcbuild/scripts/clink.pl | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/compat/vcbuild/scripts/clink.pl b/compat/vcbuild/scripts/clink.pl\nindex 61ad084a7b..df167d1e1a 100755\n--- a/compat/vcbuild/scripts/clink.pl\n+++ b/compat/vcbuild/scripts/clink.pl\n@@ -66,7 +66,7 @@\n \t\t}\n \t\tpush(@args, $lib);\n \t} elsif (\"$arg\" eq \"-lexpat\") {\n-\t\tpush(@args, \"expat.lib\");\n+\t\tpush(@args, \"libexpat.lib\");\n \t} elsif (\"$arg\" =~ /^-L/ && \"$arg\" ne \"-LTCG\") {\n \t\t$arg =~ s/^-L/-LIBPATH:/;\n \t\tpush(@lflags, $arg);\n\nbase-commit: e19713638985533ce461db072b49112da5bd2042\n-- \ngitgitgadget\n"},{"id":"404950","messageId":"20200903000640.GD4035286@google.com","threadId":"54181","inReplyTo":"pull.722.git.1599077798953.gitgitgadget@gmail.com","subject":"Re: [PATCH] vcbuild: fix library name for expat with make MSVC=1","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2020-09-03T00:06:40Z","receivedAt":"2020-09-03T00:06:46Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"(cc-ing a couple of Windows experts)\nOrgad Shaneh wrote:\n\n> Subject: vcbuild: fix library name for expat with make MSVC=1\n\nDo you have more details?  For example, what error message does the\nbuild produce without this change?\n\n> Signed-off-by: Orgad Shaneh <orgads@gmail.com>\n> ---\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-722%2Forgads%2Fvcbuild-expat-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-722/orgads/vcbuild-expat-v1\n> Pull-Request: https://github.com/gitgitgadget/git/pull/722\n>\n>  compat/vcbuild/scripts/clink.pl | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n\nI'm ignorant enough about the platform-specific details involved that\nI'd like an Ack from one of the Windows folks.\n\nThanks,\nJonathan\n\n> diff --git a/compat/vcbuild/scripts/clink.pl b/compat/vcbuild/scripts/clink.pl\n> index 61ad084a7b..df167d1e1a 100755\n> --- a/compat/vcbuild/scripts/clink.pl\n> +++ b/compat/vcbuild/scripts/clink.pl\n> @@ -66,7 +66,7 @@\n>  \t\t}\n>  \t\tpush(@args, $lib);\n>  \t} elsif (\"$arg\" eq \"-lexpat\") {\n> -\t\tpush(@args, \"expat.lib\");\n> +\t\tpush(@args, \"libexpat.lib\");\n>  \t} elsif (\"$arg\" =~ /^-L/ && \"$arg\" ne \"-LTCG\") {\n>  \t\t$arg =~ s/^-L/-LIBPATH:/;\n>  \t\tpush(@lflags, $arg);\n> \n> base-commit: e19713638985533ce461db072b49112da5bd2042\n> -- \n> gitgitgadget\n"},{"id":"404952","messageId":"xmqqk0xba9zr.fsf@gitster.c.googlers.com","threadId":"54181","inReplyTo":"20200903000640.GD4035286@google.com","subject":"Re: [PATCH] vcbuild: fix library name for expat with make MSVC=1","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-09-03T02:07:36Z","receivedAt":"2020-09-03T02:07:46Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Nieder <jrnieder@gmail.com> writes:\n\n> (cc-ing a couple of Windows experts)\n> Orgad Shaneh wrote:\n>\n>> Subject: vcbuild: fix library name for expat with make MSVC=1\n>\n> Do you have more details?  For example, what error message does the\n> build produce without this change?\n\nPresumably you'd get an error at link time, saying either 'no such\nlibrary: expat.lib', or 'symbol X not found' for symbols that were\nsupposed to come from libexpat.lib.\n\nI do not think we want to see exact error message.  If an empty body\nof the log message bothers us, I probably would say that it is\nsufficient to write something like\n\n    The name of the expat library is libexpat.lib, not expat.lib;\n    otherwise we'd get linkage errors.\n\n> I'm ignorant enough about the platform-specific details involved that\n> I'd like an Ack from one of the Windows folks.\n\nI saw Dscho looked at both pull requests and commented on them, but\nhaven't seen him (or anybody else) acking or nacking the version\nthat was submitted.  It would be nice to see an Ack from Windows'\nside.\n\nThanks.\n"},{"id":"404963","messageId":"nycvar.QRO.7.76.6.2009030341540.56@tvgsbejvaqbjf.bet","threadId":"54181","inReplyTo":"pull.722.git.1599077798953.gitgitgadget@gmail.com","subject":"Re: [PATCH] vcbuild: fix library name for expat with make MSVC=1","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2020-09-03T01:42:19Z","receivedAt":"2020-09-03T10:06:47Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Orgad,\n\nOn Wed, 2 Sep 2020, Orgad Shaneh via GitGitGadget wrote:\n\n> From: Orgad Shaneh <orgads@gmail.com>\n>\n> Signed-off-by: Orgad Shaneh <orgads@gmail.com>\n> ---\n>     vcbuild: fix library name for expat with make MSVC=1\n>\n>     Signed-off-by: Orgad Shaneh orgads@gmail.com [orgads@gmail.com]\n\nAs can be seen at\nhttps://dev.azure.com/git/git/_build/results?buildId=2065&view=artifacts&type=publishedArtifacts,\nthis change is correct.\n\nACK.\n\nThank you,\nDscho\n\n>\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-722%2Forgads%2Fvcbuild-expat-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-722/orgads/vcbuild-expat-v1\n> Pull-Request: https://github.com/gitgitgadget/git/pull/722\n>\n>  compat/vcbuild/scripts/clink.pl | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/compat/vcbuild/scripts/clink.pl b/compat/vcbuild/scripts/clink.pl\n> index 61ad084a7b..df167d1e1a 100755\n> --- a/compat/vcbuild/scripts/clink.pl\n> +++ b/compat/vcbuild/scripts/clink.pl\n> @@ -66,7 +66,7 @@\n>  \t\t}\n>  \t\tpush(@args, $lib);\n>  \t} elsif (\"$arg\" eq \"-lexpat\") {\n> -\t\tpush(@args, \"expat.lib\");\n> +\t\tpush(@args, \"libexpat.lib\");\n>  \t} elsif (\"$arg\" =~ /^-L/ && \"$arg\" ne \"-LTCG\") {\n>  \t\t$arg =~ s/^-L/-LIBPATH:/;\n>  \t\tpush(@lflags, $arg);\n>\n> base-commit: e19713638985533ce461db072b49112da5bd2042\n> --\n> gitgitgadget\n>\n"}]}