[PATCH] gc: fix some sparse 'symbol not declared' warnings

Ramsay Jones· Jul 9, 2020, 00:23 UTC · lore

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---

Hi Derrick,

If you need to re-roll your 'ds/maintenance' branch, could you please squash this into the relevant patches. The first hunk should be squashed into commit a138b8ff61 (maintenance: create basic maintenance runner, 2020-07-07) and the second hunk into commit aca963ff39 (maintenance: initialize task array and hashmap, 2020-07-07).

Thanks!

ATB, Ramsay Jones

 builtin/gc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Show changes to builtin/gc.c +4 −4

diff --git a/builtin/gc.c b/builtin/gc.c
index c3531561c2..de029d687b 100644
--- a/builtin/gc.c
+++ b/builtin/gc.c
@@ -716,7 +716,7 @@ static const char * const builtin_maintenance_usage[] = {
 	NULL
 };
 
-struct maintenance_opts {
+static struct maintenance_opts {
 	int auto_flag;
 	int quiet;
 	int tasks_selected;
@@ -1297,9 +1297,9 @@ static int task_entry_cmp(const void *unused_cmp_data,
 	return strcasecmp(e1->name, name ? name : e2->name);
 }
 
-struct maintenance_task *tasks[MAX_NUM_TASKS];
-int num_tasks;
-struct hashmap task_map;
+static struct maintenance_task *tasks[MAX_NUM_TASKS];
+static int num_tasks;
+static struct hashmap task_map;
 
 static int compare_tasks_by_selection(const void *a_, const void *b_)
 {

-- 
2.27.0

Derrick Stolee· Jul 9, 2020, 11:21 UTC · re: Ramsay Jones · lore

Re: [PATCH] gc: fix some sparse 'symbol not declared' warnings

On 7/8/2020 8:23 PM, Ramsay Jones wrote:

Show 11 quoted lines

> 
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
> 
> Hi Derrick,
> 
> If you need to re-roll your 'ds/maintenance' branch, could you please
> squash this into the relevant patches. The first hunk should be squashed
> into commit a138b8ff61 (maintenance: create basic maintenance runner,
> 2020-07-07) and the second hunk into commit aca963ff39 (maintenance:
> initialize task array and hashmap, 2020-07-07).

Can do, thanks! Sorry for the disruption.

-Stolee

patchgc: fix some sparse 'symbol not declared' warnings