# [PATCH] gc: fix some sparse 'symbol not declared' warnings 2 messages from 2020-07-09 to 2020-07-09. Participants: Ramsay Jones, Derrick Stolee. Thread: https://gitlist.dev/t/53820 ## Ramsay Jones, 2020-07-09 00:23 Subject: [PATCH] gc: fix some sparse 'symbol not declared' warnings Message-ID: <9c9164e2-0fff-7211-a79a-f4c546d2cedd@ramsayjones.plus.com> URL: https://gitlist.dev/e/9c9164e2-0fff-7211-a79a-f4c546d2cedd%40ramsayjones.plus.com ``` Signed-off-by: Ramsay Jones --- Hi Derrick, If you need to re-roll your 'ds/maintenance' branch, could you please squash this into the relevant patches. The first hunk should be squashed into commit a138b8ff61 (maintenance: create basic maintenance runner, 2020-07-07) and the second hunk into commit aca963ff39 (maintenance: initialize task array and hashmap, 2020-07-07). Thanks! ATB, Ramsay Jones builtin/gc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/builtin/gc.c b/builtin/gc.c index c3531561c2..de029d687b 100644 --- a/builtin/gc.c +++ b/builtin/gc.c @@ -716,7 +716,7 @@ static const char * const builtin_maintenance_usage[] = { NULL }; -struct maintenance_opts { +static struct maintenance_opts { int auto_flag; int quiet; int tasks_selected; @@ -1297,9 +1297,9 @@ static int task_entry_cmp(const void *unused_cmp_data, return strcasecmp(e1->name, name ? name : e2->name); } -struct maintenance_task *tasks[MAX_NUM_TASKS]; -int num_tasks; -struct hashmap task_map; +static struct maintenance_task *tasks[MAX_NUM_TASKS]; +static int num_tasks; +static struct hashmap task_map; static int compare_tasks_by_selection(const void *a_, const void *b_) { -- 2.27.0 ``` ## Derrick Stolee, 2020-07-09 11:21 Subject: Re: [PATCH] gc: fix some sparse 'symbol not declared' warnings Message-ID: <1acadbb6-3c28-0ce0-7578-a0af2b034a3c@gmail.com> URL: https://gitlist.dev/e/1acadbb6-3c28-0ce0-7578-a0af2b034a3c%40gmail.com In-Reply-To: <9c9164e2-0fff-7211-a79a-f4c546d2cedd@ramsayjones.plus.com> ``` On 7/8/2020 8:23 PM, Ramsay Jones wrote: > > Signed-off-by: Ramsay Jones > --- > > Hi Derrick, > > If you need to re-roll your 'ds/maintenance' branch, could you please > squash this into the relevant patches. The first hunk should be squashed > into commit a138b8ff61 (maintenance: create basic maintenance runner, > 2020-07-07) and the second hunk into commit aca963ff39 (maintenance: > initialize task array and hashmap, 2020-07-07). Can do, thanks! Sorry for the disruption. -Stolee ```