{"thread":{"id":"53820","subject":"[PATCH] gc: fix some sparse 'symbol not declared' warnings","startedAt":"2020-07-09T00:23:18Z","lastAt":"2020-07-09T11:21:48Z","messageCount":2,"participants":["Ramsay Jones","Derrick Stolee"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"401208","messageId":"9c9164e2-0fff-7211-a79a-f4c546d2cedd@ramsayjones.plus.com","threadId":"53820","inReplyTo":null,"subject":"[PATCH] gc: fix some sparse 'symbol not declared' warnings","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2020-07-09T00:23:12Z","receivedAt":"2020-07-09T00:23:18Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Derrick,\n\nIf you need to re-roll your 'ds/maintenance' branch, could you please\nsquash this into the relevant patches. The first hunk should be squashed\ninto commit a138b8ff61 (maintenance: create basic maintenance runner,\n2020-07-07) and the second hunk into commit aca963ff39 (maintenance:\ninitialize task array and hashmap, 2020-07-07).\n\nThanks!\n\nATB,\nRamsay Jones\n\n builtin/gc.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/builtin/gc.c b/builtin/gc.c\nindex c3531561c2..de029d687b 100644\n--- a/builtin/gc.c\n+++ b/builtin/gc.c\n@@ -716,7 +716,7 @@ static const char * const builtin_maintenance_usage[] = {\n \tNULL\n };\n \n-struct maintenance_opts {\n+static struct maintenance_opts {\n \tint auto_flag;\n \tint quiet;\n \tint tasks_selected;\n@@ -1297,9 +1297,9 @@ static int task_entry_cmp(const void *unused_cmp_data,\n \treturn strcasecmp(e1->name, name ? name : e2->name);\n }\n \n-struct maintenance_task *tasks[MAX_NUM_TASKS];\n-int num_tasks;\n-struct hashmap task_map;\n+static struct maintenance_task *tasks[MAX_NUM_TASKS];\n+static int num_tasks;\n+static struct hashmap task_map;\n \n static int compare_tasks_by_selection(const void *a_, const void *b_)\n {\n-- \n2.27.0\n"},{"id":"401240","messageId":"1acadbb6-3c28-0ce0-7578-a0af2b034a3c@gmail.com","threadId":"53820","inReplyTo":"9c9164e2-0fff-7211-a79a-f4c546d2cedd@ramsayjones.plus.com","subject":"Re: [PATCH] gc: fix some sparse 'symbol not declared' warnings","fromName":"Derrick Stolee","fromEmail":"stolee@gmail.com","sentAt":"2020-07-09T11:21:46Z","receivedAt":"2020-07-09T11:21:48Z","isPatch":true,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"On 7/8/2020 8:23 PM, Ramsay Jones wrote:\n> \n> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n> ---\n> \n> Hi Derrick,\n> \n> If you need to re-roll your 'ds/maintenance' branch, could you please\n> squash this into the relevant patches. The first hunk should be squashed\n> into commit a138b8ff61 (maintenance: create basic maintenance runner,\n> 2020-07-07) and the second hunk into commit aca963ff39 (maintenance:\n> initialize task array and hashmap, 2020-07-07).\n\nCan do, thanks! Sorry for the disruption.\n\n-Stolee\n"}]}